From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38515) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wu3H1-0007xH-4a for qemu-devel@nongnu.org; Mon, 09 Jun 2014 13:22:23 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Wu3Gw-0007qs-Sh for qemu-devel@nongnu.org; Mon, 09 Jun 2014 13:22:19 -0400 Received: from mx1.redhat.com ([209.132.183.28]:37446) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wu3Gw-0007qn-KW for qemu-devel@nongnu.org; Mon, 09 Jun 2014 13:22:14 -0400 Message-ID: <5395ED3D.7030201@redhat.com> Date: Mon, 09 Jun 2014 11:22:05 -0600 From: Eric Blake MIME-Version: 1.0 References: In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="grj9JloUsS4rldE2LvmGnG6Ck9RbjQc2j" Subject: Re: [Qemu-devel] [PATCH v4 12/29] numa: add -numa node, memdev= option List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Hu Tao , qemu-devel@nongnu.org Cc: Yasunori Goto , Igor Mammedov , "Michael S. Tsirkin" , Eduardo Habkost , Paolo Bonzini This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --grj9JloUsS4rldE2LvmGnG6Ck9RbjQc2j Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 06/09/2014 04:25 AM, Hu Tao wrote: > From: Paolo Bonzini >=20 > This option provides the infrastructure for binding guest NUMA nodes > to host NUMA nodes. For example: >=20 > -object memory-ram,size=3D1024M,policy=3Dbind,host-nodes=3D0,id=3Dram-= node0 \ > -numa node,nodeid=3D0,cpus=3D0,memdev=3Dram-node0 \ > -object memory-ram,size=3D1024M,policy=3Dinterleave,host-nodes=3D1-3,i= d=3Dram-node1 \ > -numa node,nodeid=3D1,cpus=3D1,memdev=3Dram-node1 >=20 > The option replaces "-numa node,mem=3D". >=20 > Signed-off-by: Paolo Bonzini > Signed-off-by: Hu Tao > --- > include/sysemu/sysemu.h | 1 + > +# @mem: #optional memory size of this node; mutually exclusive with @m= emdev. > +# Equally divide total memory among nodes if both @mem and @memd= ev are > +# omitted. > +# > +# @memdev: #optional memory backend object. If specified for one node= , > +# it must be specified for all nodes. > # > # Since: 2.1 > ## > @@ -4753,4 +4757,5 @@ > 'data': { > '*nodeid': 'uint16', > '*cpus': ['uint16'], > - '*mem': 'size' }} > + '*mem': 'size', > + '*memdev': 'str' }} This looks okay. > diff --git a/qemu-options.hx b/qemu-options.hx > index d3cd2ce..e448d33 100644 > --- a/qemu-options.hx > +++ b/qemu-options.hx > @@ -95,16 +95,20 @@ specifies the maximum number of hotpluggable CPUs. > ETEXI > =20 > DEF("numa", HAS_ARG, QEMU_OPTION_numa, > - "-numa node[,mem=3Dsize][,cpus=3Dcpu[-cpu]][,nodeid=3Dnode]\n", QE= MU_ARCH_ALL) > + "-numa node[,mem=3Dsize][,memdev=3Did][,cpus=3Dcpu[-cpu]][,nodeid=3D= node]\n", QEMU_ARCH_ALL) But this implies both parameters can be used at once. Is it worth rewriting in two lines: "-numa node[,mem=3Dsize][,cpus=3Dcpu[-cpu]][,nodeid=3Dnode]\n" "-numa node[,memdev=3Did][,cpus=3Dcpu[-cpu]][,nodeid=3Dnode]\n" to make the exclusion clearer? > -to allocate RAM and vCPUs respectively. > +to allocate RAM and vCPU srespectively, and possibly @option{-object} s/vCPU srespectively/vCPUs respectively/ --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --grj9JloUsS4rldE2LvmGnG6Ck9RbjQc2j Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJTle09AAoJEKeha0olJ0NqTVwIAJJaMPN5FeMXUiDMejHPUauS i6w9BXkak6XyLBPQlJKcTGrc6tF4NlhYqUXfhtW/T168xANuxBRKvX0GSBATU694 fdsCVynya0c+Rq+R0MO4w8pC+6owl1fRzXN4WnnVmWKtJ3IZwfMK2jretJf52J9h Z+LyR1HjTXzmcelCNaT1aA+O6L1169aFoVtzZeLTdznsywCeBpAPgDxdT9uPPJrB y51wOyofnehpcuWdem5s+7/YsGiw3wlXEa2YEhbt7avNSbKW+orG2XnRViDWj/Q3 8GjOXPMQWUH28nl0v2sNq0V08q0VWlUlI9kJ18h4cz+weMRgqTBC0ktK+n35FbY= =v1kH -----END PGP SIGNATURE----- --grj9JloUsS4rldE2LvmGnG6Ck9RbjQc2j--