From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35542) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WuBvM-0003Y4-RT for qemu-devel@nongnu.org; Mon, 09 Jun 2014 22:36:37 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WuBvI-00021n-Gm for qemu-devel@nongnu.org; Mon, 09 Jun 2014 22:36:32 -0400 Received: from mx1.redhat.com ([209.132.183.28]:58373) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WuBvI-00021T-9C for qemu-devel@nongnu.org; Mon, 09 Jun 2014 22:36:28 -0400 Message-ID: <53966F21.4030902@redhat.com> Date: Mon, 09 Jun 2014 20:36:17 -0600 From: Eric Blake MIME-Version: 1.0 References: <463560c2fbe9c476d4a500008618f01740cd5631.1402299637.git.hutao@cn.fujitsu.com> <53963D1B.4090900@redhat.com> <20140610022901.GH29724@G08FNSTD100614.fnst.cn.fujitsu.com> In-Reply-To: <20140610022901.GH29724@G08FNSTD100614.fnst.cn.fujitsu.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="R9IeVgbStVBuDblIPvOiTEVQBstkePMug" Subject: Re: [Qemu-devel] [PATCH v4 02/29] NUMA: check if the total numa memory size is equal to ram_size List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Hu Tao Cc: Eduardo Habkost , "Michael S. Tsirkin" , qemu-devel@nongnu.org, Paolo Bonzini , Igor Mammedov , Yasunori Goto , Wanlong Gao This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --R9IeVgbStVBuDblIPvOiTEVQBstkePMug Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 06/09/2014 08:29 PM, Hu Tao wrote: > On Mon, Jun 09, 2014 at 05:02:51PM -0600, Eric Blake wrote: >> On 06/09/2014 04:25 AM, Hu Tao wrote: >>> From: Wanlong Gao >>> >>> If the total number of the assigned numa nodes memory is not >>> equal to the assigned ram size, it will write the wrong data >>> to ACPI table, then the guest will ignore the wrong ACPI table >>> and recognize all memory to one node. It's buggy, we should >>> check it to ensure that we write the right data to ACPI table. >>> >>> Signed-off-by: Wanlong Gao >>> Reviewed-by: Eduardo Habkost >>> Signed-off-by: Paolo Bonzini >>> Signed-off-by: Hu Tao >>> --- >>> numa.c | 14 ++++++++++++++ >>> 1 file changed, 14 insertions(+) >>> >> >>> + if (numa_total !=3D ram_size) { >>> + error_report("qemu: total memory size for NUMA nodes (%"= PRIu64 ")" >>> + " should equal to RAM size (" RAM_ADDR_FMT = ")\n", >> >> error_report() should not include trailing \n >=20 > Thanks. Sorry for not noticing earlier, but a couple more things to fix: error_report already prefixes the error message, so s/qemu: // The grammar is a bit awkward; how about: "total memory for NUMA nodes (%" PRIu64 ") should equal RAM size (" RAM_ADDR_FMT ")" --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --R9IeVgbStVBuDblIPvOiTEVQBstkePMug Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJTlm8hAAoJEKeha0olJ0NqxNYH/0nTiE4uW1qQ6HsBp56gat0c PV21NmWEqHnRXr/6WNtqK5hXbSnjWbt58uJ9a1eHXX5Ww6hFVA3MMVPanIfcTASi D5XdBShvtaw5ncLu9taqgkGJumVEHkX9iKFKPrkksUhZKaZRNRLd6+s5sSc+BRPV W22aQipPEMY6lHvC5QMLAYWR/LtO31J4CqzofUbSpCC+XDeR7uRP2tOJLjUQaUF3 WrkEJV+GSDu0UPAaLxgc47SO3Rlaa3iLOLH/bKT22IBVxEed2Yfkp0psGl2DK5xC 1sw//BXTBpguCYSy8IXrCuvjjVi2V5voWbv/abtKKmDmb7xNVSjeaKlp6hRbcxA= =W8uR -----END PGP SIGNATURE----- --R9IeVgbStVBuDblIPvOiTEVQBstkePMug--