From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39244) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WuHvR-00088E-N3 for qemu-devel@nongnu.org; Tue, 10 Jun 2014 05:01:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WuHvL-0003nx-Ik for qemu-devel@nongnu.org; Tue, 10 Jun 2014 05:01:01 -0400 Received: from mx1.redhat.com ([209.132.183.28]:8072) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WuHvL-0003ni-A6 for qemu-devel@nongnu.org; Tue, 10 Jun 2014 05:00:55 -0400 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s5A90ra2003774 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Tue, 10 Jun 2014 05:00:54 -0400 Message-ID: <5396C942.3010901@redhat.com> Date: Tue, 10 Jun 2014 11:00:50 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1402385392-15035-1-git-send-email-stefanha@redhat.com> In-Reply-To: <1402385392-15035-1-git-send-email-stefanha@redhat.com> Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 0/3] dataplane: add query-blockstats support List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi , qemu-devel@nongnu.org Cc: Kevin Wolf , Fam Zheng , Max Reitz Il 10/06/2014 09:29, Stefan Hajnoczi ha scritto: > This series adds blockstats support to virtio-blk data-plane and protects > query-blockstats from races with the dataplane IOThread. > > Stefan Hajnoczi (3): > dataplane: add bdrv_acct_*() accounting > block: make bdrv_query_stats() static > block: acquire AioContext is qmp_query_blockstats() > > block/qapi.c | 6 +++++- > hw/block/dataplane/virtio-blk.c | 10 ++++++++++ > include/block/qapi.h | 1 - > 3 files changed, 15 insertions(+), 2 deletions(-) > ACK to patches 2 and 3. Regarding patch 1 it's nice that the change is so trivial so I'm not objecting to the patch. However, Fam's patches for VirtIOBlockReq{,uest} unification provide another way to achieve this. If we could drop do_rdwr_cmd in favor of virtio_blk_handle_read and virtio_blk_handle_write, we would get for free both blockstats and rerror/werror support. What do you think? Paolo