From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39914) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WuHxl-0000nX-IU for qemu-devel@nongnu.org; Tue, 10 Jun 2014 05:03:31 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WuHxf-0004gN-Eq for qemu-devel@nongnu.org; Tue, 10 Jun 2014 05:03:25 -0400 Received: from mx1.redhat.com ([209.132.183.28]:17445) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WuHxf-0004gH-51 for qemu-devel@nongnu.org; Tue, 10 Jun 2014 05:03:19 -0400 Message-ID: <5396C9D3.9040805@redhat.com> Date: Tue, 10 Jun 2014 11:03:15 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1402383802-14252-1-git-send-email-stefanha@redhat.com> In-Reply-To: <1402383802-14252-1-git-send-email-stefanha@redhat.com> Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 0/3] dataplane: introduce virtio-blk.iothread property List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi , qemu-devel@nongnu.org Cc: Kevin Wolf , Andreas Faerber Il 10/06/2014 09:03, Stefan Hajnoczi ha scritto: > Up until now the virtio-blk x-data-plane and x-iothread features have been > experimental. It's time to commit to a final command-line interface: > > qemu -object iothread,id=iothread0 \ > -drive if=none,id=drive0,file=test.qcow2,format=qcow2 \ > -device virtio-blk-pci,iothread=iothread0,drive=drive0 > > The iothread= property associates a virtio-blk-pci instance with an > IOThread. If the iothread property is not given, the non-dataplane code path > is used. This means dataplane is not the default yet. > > The x-data-plane=on|off property is now obsolete but will be kept around for at > least another release cycle to give users a chance to migrate. > > Stefan Hajnoczi (3): > virtio-blk: replace x-iothread with iothread link property > qdev: drop iothread property type > virtio-blk: remove need for explicit x-data-plane=on option > > hw/block/dataplane/virtio-blk.c | 2 +- > hw/block/virtio-blk.c | 12 +++++++++- > hw/core/qdev-properties-system.c | 50 ---------------------------------------- > hw/s390x/s390-virtio-bus.c | 2 ++ > hw/s390x/virtio-ccw.c | 2 ++ > hw/virtio/virtio-pci.c | 2 ++ > include/hw/qdev-properties.h | 3 --- > 7 files changed, 18 insertions(+), 55 deletions(-) > I don't yet see object_property_add_alias, apart from that Reviewed-by: Paolo Bonzini