From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:55628)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <raimue@codingfarm.de>) id 1WuJDE-000585-Av
	for qemu-devel@nongnu.org; Tue, 10 Jun 2014 06:23:35 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <raimue@codingfarm.de>) id 1WuJD6-0006Ed-JJ
	for qemu-devel@nongnu.org; Tue, 10 Jun 2014 06:23:28 -0400
Received: from codingfarm.de ([79.140.41.77]:36460)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <raimue@codingfarm.de>) id 1WuJD6-0006ER-D8
	for qemu-devel@nongnu.org; Tue, 10 Jun 2014 06:23:20 -0400
Message-ID: <5396DCA4.5090909@codingfarm.de>
Date: Tue, 10 Jun 2014 12:23:32 +0200
From: =?ISO-8859-1?Q?Rainer_M=FCller?= <raimue@codingfarm.de>
MIME-Version: 1.0
References: <CAKKtb+tP-J2sVbR_ZcgOBpu=aC+jDW3E2pUv5BLashL5Ti4TyA@mail.gmail.com>
	<CAFEAcA93K_=TfPC3qTO3wfwxoSPjXqyf3pBEvj2VHU-E2sLwfA@mail.gmail.com>
	<CAKKtb+szAOsdt2po3Yw=51YG-3qQ31rFb8oqD-HiRAgLevvcvg@mail.gmail.com>
	<CAFEAcA9=w1js-ZmeibJTwhxTJUxx3Ea8HG-gbNxO12QL-g2PVA@mail.gmail.com>
	<CAKKtb+uYdHoSLidyadizmm_B29Wiink4-Ozf3yqUeOssKOKQcg@mail.gmail.com>
	<CAFEAcA_8b7eX=oABvL9NuAcVvjSAXS90E012fq1x3FvCHgJstA@mail.gmail.com>
	<5322F612.6070708@redhat.com> <lmprsk$4dv$1@ger.gmane.org>
	<CAFEAcA9ZJix-w1euD+kcsNOKU5V7hPJqKHOn-FD2jEPNOKJ7eA@mail.gmail.com>
	<20140606020418.GF10963@T430.nay.redhat.com>
In-Reply-To: <20140606020418.GF10963@T430.nay.redhat.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] Problems compiling HEAD on Mac OS X 10.9.2
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Fam Zheng <famz@redhat.com>, Peter Maydell <peter.maydell@linaro.org>
Cc: QEMU Developers <qemu-devel@nongnu.org>

On 2014-06-06 04:04, Fam Zheng wrote:
>> Ugh. This was supposed to be fixed by commit 6295b98d7b767c.
>> Fam, can you re-check your fix, please?
>>
> 
> I don't understand that fix now, looks like it was moved onto a wrong list.
> 
> Rainer, does this below patch work for you? (we can't duplicate object, so sort
> is required there).

No, unfortunately this does not work. With this patch, I end up with:

$ make V=1 qemu-img
...
... qemu-img.o qemu-io-cmds.o qemu-timer.o thread-pool.o libqemuutil.a libqemustub.a  -lz -L/opt/local/lib -lcurl -L/opt/local/lib -lssh2 -Wl,-headerpad_max_install_names -arch x86_64 -L/opt/local/lib -Wl,-headerpad_max_install_names -arch -lcurl -lssh2 -lz x86_64 -L/opt/local/lib -lgthread-2.0 -lglib-2.0 -lintl   -lz -lz
clang: error: no such file or directory: 'x86_64'
clang: error: invalid arch name '-arch -lcurl'
make: *** [qemu-img] Error 1


You really can't just sort the words as their order is important, at 
least for some options such as "-arch" and its argument.

>>From config-host.mak:

  LIBSSH2_LIBS=-L/opt/local/lib -lssh2 -Wl,-headerpad_max_install_names -arch x86_64

I don't understand the make function $(extract-libs) here. First the 
contents of $o-libs is added as-is, but then it is added again filtered 
through $(expand-objs). What is the purpose of adding it twice?

Regarding your proposed patch, it doesn't matter whether you sort the 
first list or the second list. Both lists include the problematic 
"-arch x86_64" linker option.

Rainer