From: Paolo Bonzini <pbonzini@redhat.com>
To: Cornelia Huck <cornelia.huck@de.ibm.com>,
Alexey Kardashevskiy <aik@ozlabs.ru>
Cc: Peter Maydell <peter.maydell@linaro.org>,
qemu-ppc@nongnu.org, qemu-devel@nongnu.org,
Alexander Graf <agraf@suse.de>
Subject: Re: [Qemu-devel] [PATCH v5 1/4] cpus: Define callback for QEMU "nmi" command
Date: Tue, 10 Jun 2014 13:45:27 +0200 [thread overview]
Message-ID: <5396EFD7.1070206@redhat.com> (raw)
In-Reply-To: <20140610134340.35a18fff.cornelia.huck@de.ibm.com>
Il 10/06/2014 13:43, Cornelia Huck ha scritto:
>> > + CPUState *cs = qemu_get_cpu(monitor_get_cpu_index());
>> > + CPUClass *cc = CPU_GET_CLASS(cs);
> Just wondering: Is CPU_GET_CLASS(NULL) really safe?
No, it's not...
>> > +
>> > + if (cs && cc->nmi_monitor_handler) {
> Or is cs == NULL simply not possible, and the code should check for
> cc != NULL here instead?
... and cc cannot be NULL either here.
Paolo
>> > + cc->nmi_monitor_handler(cs, errp);
next prev parent reply other threads:[~2014-06-10 11:45 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-10 6:17 [Qemu-devel] [PATCH v5 0/4] cpus: Add generic "nmi" monitor command support Alexey Kardashevskiy
2014-06-10 6:18 ` [Qemu-devel] [PATCH v5 1/4] cpus: Define callback for QEMU "nmi" command Alexey Kardashevskiy
2014-06-10 11:43 ` Cornelia Huck
2014-06-10 11:45 ` Paolo Bonzini [this message]
2014-06-10 15:39 ` Alexey Kardashevskiy
2014-06-10 6:18 ` [Qemu-devel] [PATCH v5 2/4] target-s390x: Migrate to new nmi_monitor_handler() CPU callback Alexey Kardashevskiy
2014-06-10 11:48 ` Cornelia Huck
2014-06-10 6:18 ` [Qemu-devel] [PATCH v5 3/4] target-i386: " Alexey Kardashevskiy
2014-06-10 6:18 ` [Qemu-devel] [PATCH v5 4/4] target-ppc: Add support for " Alexey Kardashevskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5396EFD7.1070206@redhat.com \
--to=pbonzini@redhat.com \
--cc=agraf@suse.de \
--cc=aik@ozlabs.ru \
--cc=cornelia.huck@de.ibm.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).