From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39898) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WuLHx-0002ZX-2d for qemu-devel@nongnu.org; Tue, 10 Jun 2014 08:36:39 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WuLHi-0006qp-Kj for qemu-devel@nongnu.org; Tue, 10 Jun 2014 08:36:29 -0400 Received: from mx1.redhat.com ([209.132.183.28]:16782) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WuLHi-0006qi-A3 for qemu-devel@nongnu.org; Tue, 10 Jun 2014 08:36:14 -0400 Message-ID: <5396FB99.30104@redhat.com> Date: Tue, 10 Jun 2014 06:35:37 -0600 From: Eric Blake MIME-Version: 1.0 References: <1402392027-9164-1-git-send-email-arei.gonglei@huawei.com> <1402392027-9164-2-git-send-email-arei.gonglei@huawei.com> In-Reply-To: <1402392027-9164-2-git-send-email-arei.gonglei@huawei.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="Eh4UsH04v684atnnnRl5fMl04jR0unjTi" Subject: Re: [Qemu-devel] [PATCH v3 1/4] json-parser: drop superfluous assignment for token variable List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: arei.gonglei@huawei.com, qemu-devel@nongnu.org Cc: ChenLiang , weidong.huang@huawei.com, luonengjun@huawei.com, lcapitulino@redhat.com, av1474@comtv.ru, kraxel@redhat.com, stefanha@redhat.com, pbonzini@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --Eh4UsH04v684atnnnRl5fMl04jR0unjTi Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 06/10/2014 03:20 AM, arei.gonglei@huawei.com wrote: > From: Gonglei >=20 > Signed-off-by: ChenLiang > Signed-off-by: Gonglei > --- > qobject/json-parser.c | 15 ++------------- > 1 file changed, 2 insertions(+), 13 deletions(-) Reviewed-by: Eric Blake > @@ -461,10 +459,8 @@ static QObject *parse_object(JSONParserContext *ct= xt, va_list *ap) > goto out; > } > } > - token =3D NULL; > } else { > - token =3D parser_context_pop_token(ctxt); > - token =3D NULL; > + (void)parser_context_pop_token(ctxt); Does the compiler warn if you drop the cast-to-void? I tend to think of it as fluff that usually doesn't add anything. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --Eh4UsH04v684atnnnRl5fMl04jR0unjTi Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJTlvuZAAoJEKeha0olJ0Nql70H/RM+0znA9arGl1CM1DPc2G8G 5lRMKkpZMYVgHLvfeUDkyEZmOZgVtLwR30ePLMnQwuEv6i9/dbzxTwCw2S25b75w hKzr8mglsFGgu6gCHIPCcJ2gRiQHpUQy28EXgk6lVEEV6/gJ0Ub2WGAiinYbpBM4 57pGDxUVGKolJOU0RpNxvviNmSAiaKMYsdtAee+EPgbAI5T9NacAhbhtkE1TYld+ uwyiUGI/W8R3j3B8yleonobj9Yfg6Dp1rhrgblxunLuynKPLkJ1/3PCn252oFigo niWLQikKGIbIuvrIwJsGHTVqoeLHsQoRlgWlzqFKLQiIlehPNieo4mkg9l+XJBg= =g7Pn -----END PGP SIGNATURE----- --Eh4UsH04v684atnnnRl5fMl04jR0unjTi--