From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50718) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WuLp1-0005pg-Kr for qemu-devel@nongnu.org; Tue, 10 Jun 2014 09:10:45 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WuLov-0003Tr-SL for qemu-devel@nongnu.org; Tue, 10 Jun 2014 09:10:39 -0400 Received: from mx1.redhat.com ([209.132.183.28]:10064) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WuLov-0003Ti-IX for qemu-devel@nongnu.org; Tue, 10 Jun 2014 09:10:33 -0400 Message-ID: <539703C6.3020509@redhat.com> Date: Tue, 10 Jun 2014 07:10:30 -0600 From: Eric Blake MIME-Version: 1.0 References: <20140610100157.11064.61717.stgit@3820> <5396F5E4.6010900@redhat.com> <20140610130353.GB27702@redhat.com> In-Reply-To: <20140610130353.GB27702@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="AhK92fBPvo5VV27PtAtnS0Wv2TKuktbsU" Subject: Re: [Qemu-devel] [PATCH v10-fix 15/18] Add the vhost-user netdev backend to the command line List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" Cc: snabb-devel@googlegroups.com, qemu-devel@nongnu.org, Nikolay Nikolaev , luke@snabb.co, a.motakis@virtualopensystems.com, tech@virtualopensystems.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --AhK92fBPvo5VV27PtAtnS0Wv2TKuktbsU Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 06/10/2014 07:03 AM, Michael S. Tsirkin wrote: > On Tue, Jun 10, 2014 at 06:11:16AM -0600, Eric Blake wrote: >> On 06/10/2014 04:02 AM, Nikolay Nikolaev wrote: >>> The supplied chardev id will be inspected for supported options. Only= >>> a socket backend, with a set path (i.e. a Unix socket) and optionally= >>> the server parameter set, will be allowed. Other options (nowait, tel= net) >>> will make the chardev unusable and the netdev will not be initialised= =2E >>> >>> +## >>> +{ 'type': 'NetdevVhostUserOptions', >>> + 'data': { >>> + 'chardev': 'str', >>> + '*vhost-force': 'bool' } } >> >> [1]...and here you call it vhost-force... >> >=20 > Should be vhostforce, consistent with tap. Oh, good point - no need to make the user have to guess which of two spellings to use. Sorry for not noticing that earlier when I was bikeshedding in my request to add a '-'. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --AhK92fBPvo5VV27PtAtnS0Wv2TKuktbsU Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJTlwPGAAoJEKeha0olJ0NqOeEH/2uUCT7SBCDAJQW5Px5jqEUi ogm0gz0s3cWzvj7CjfEs5EZQUy/GJiZLAFTrUoGyhnK29PSTFBQGe3LI154sBU32 uWDKU2YJw/i3uhFClT3vFseYKETNWQALoNozSI8TVRt9aJ4QImF1Q/V9SPBOJH09 tTCvkbft3wIvK4uQzCtbjQX2CL1tDxyL3xlIIW9v71aSJEmZ5Oy1J/p/GlWlTjfw mu3lhyebdpQCCYCsMn8zVdOKOkQ/rLDRfRGxbemYiXNjrsXD8cP3k9ehOX5bFON7 1jmS+cQucOyEz3u15CM4ald9VBKOuv0FH5UpHOKY8bTORyiH6nPG6QcByttAbU0= =744Z -----END PGP SIGNATURE----- --AhK92fBPvo5VV27PtAtnS0Wv2TKuktbsU--