From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37308) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WuOvu-0001lW-Cc for qemu-devel@nongnu.org; Tue, 10 Jun 2014 12:30:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WuOvl-00009T-Ag for qemu-devel@nongnu.org; Tue, 10 Jun 2014 12:29:58 -0400 Sender: Paolo Bonzini Message-ID: <53973277.4090500@redhat.com> Date: Tue, 10 Jun 2014 18:29:43 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1401869330-32449-1-git-send-email-aik@ozlabs.ru> <1401869330-32449-2-git-send-email-aik@ozlabs.ru> <20140610093951.6dd64ea4@redhat.com> <20140610164107.249d8290.cornelia.huck@de.ibm.com> <20140610104847.1cb5a424@redhat.com> In-Reply-To: <20140610104847.1cb5a424@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v3 1/4] cpus: Define NMI callback List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Luiz Capitulino , Cornelia Huck Cc: qemu-devel@nongnu.org, Stefan Hajnoczi , Alexey Kardashevskiy , Alexander Graf , Markus Armbruster , qemu-ppc@nongnu.org, Alex Bligh , =?ISO-8859-1?Q?Andreas_F=E4rber?= , Richard Henderson Il 10/06/2014 16:48, Luiz Capitulino ha scritto: > > The s390 restart interrupt is a per-vcpu interrupt, which we really > > don't want to inject on _all_ vcpus. OTOH, we want to inject that > > interrupt on any vcpu - we don't care which one it is. So I'd really > > like an "inject nmi on default cpu" option. > > We could define a default CPU for the command. What isn't going to work > is to use the human monitor's "current CPU" concept (set with the cpu > command). It isn't going to work, but to me it seems like a bug. Why was the NMI command even converted to QAPI if it cannot work? Let's just use monitor_set_cpu from qmp_cpu and call it a day. The amount of churn that Alexey is going through for this feature is unreasonable. Paolo