From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:43152)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1WuPEN-0003e0-Ll
	for qemu-devel@nongnu.org; Tue, 10 Jun 2014 12:49:11 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1WuPEG-0007tf-6p
	for qemu-devel@nongnu.org; Tue, 10 Jun 2014 12:49:03 -0400
Received: from mx1.redhat.com ([209.132.183.28]:38136)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1WuPEF-0007qb-KZ
	for qemu-devel@nongnu.org; Tue, 10 Jun 2014 12:48:55 -0400
Message-ID: <539736F3.6080605@redhat.com>
Date: Tue, 10 Jun 2014 18:48:51 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1402411908-25821-1-git-send-email-peter.maydell@linaro.org>
	<1402411908-25821-2-git-send-email-peter.maydell@linaro.org>
	<53972F12.4030900@redhat.com>
	<CAFEAcA_fL=t6GeHhygJTYSKBggakG9ZzErf6QVdoq+K8FP5rCA@mail.gmail.com>
	<539730FD.8070204@redhat.com>
	<CAFEAcA-dgc5vCRYGpe9vphL=foU3jK_JtxSaExirYsz2XOZxYw@mail.gmail.com>
In-Reply-To: <CAFEAcA-dgc5vCRYGpe9vphL=foU3jK_JtxSaExirYsz2XOZxYw@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 1/2] hw/arm/virt: Provide flash devices for
	boot ROMs
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Michael Casadevall <Michael.casadevall@linaro.org>, QEMU Developers <qemu-devel@nongnu.org>, Christoffer Dall <christoffer.dall@linaro.org>, Patch Tracking <patches@linaro.org>

Il 10/06/2014 18:38, Peter Maydell ha scritto:
> On 10 June 2014 17:23, Paolo Bonzini <pbonzini@redhat.com> wrote:
>> Il 10/06/2014 18:17, Peter Maydell ha scritto:
>>
>>>>>>> +    create_one_flash("virt.flash0", flashbase, flashsize);
>>>>>>> +    create_one_flash("virt.flash1", flashbase + flashsize,
>>>>>>> flashsize);
>>>>
>>>>>
>>>>>
>>>>> What happens if you specify both -bios and -drive if=pflash?  Can you
>>>>> check
>>>>> that the user does not specify both?
>>>
>>> We'll create the device and then overlay it with the "ROM"
>>> image, same as for vexpress. (If the bios image is short
>>> then the underlying pflash contents will be visible.)
>>
>>
>> Could you provide slightly saner semantics for -M virt? :)
>
> Heh. How about:
>  * if both bios_name and pflash drive 0 specified, this is an error
>  * otherwise use whichever we have
>  * (NB that bios_name + pflash drive 1 is a reasonable combination)

Yes, it is.

> vexpress should do this too, for consistency.

If it's okay for you, why not.

Paolo

> (Actually ideally I'd just make bios_name be a convenient
> shortcut for specifying a block backend for pflash that's
> readonly and permits undersized backing files, but I don't
> think we can easily do that right now.)
>
> thanks
> -- PMM
>