From: Paolo Bonzini <pbonzini@redhat.com>
To: Stefan Hajnoczi <stefanha@redhat.com>, qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>, Andreas Faerber <afaerber@suse.de>
Subject: Re: [Qemu-devel] [PATCH 1/3] virtio-blk: replace x-iothread with iothread link property
Date: Tue, 10 Jun 2014 20:35:35 +0200 [thread overview]
Message-ID: <53974FF7.5010504@redhat.com> (raw)
In-Reply-To: <1402383802-14252-2-git-send-email-stefanha@redhat.com>
Il 10/06/2014 09:03, Stefan Hajnoczi ha scritto:
> @@ -193,6 +193,8 @@ static void s390_virtio_blk_instance_init(Object *obj)
> object_property_add_child(obj, "virtio-backend", OBJECT(&dev->vdev), NULL);
> object_unref(OBJECT(&dev->vdev));
> qdev_alias_all_properties(DEVICE(&dev->vdev), obj);
> + object_property_add_alias(obj, "iothread", OBJECT(&dev->vdev),"iothread",
> + &error_abort);
Actually this won't work. Link properties have to have a LinkProperty
opaque.
The series I posted to add a "resolve" callback for properties can be
used here, fixing object_property_add_alias to add a "resolve" callback
to the newly-created property.
My ack for this patch still stands, it's just a matter of patch ordering.
Paolo
next prev parent reply other threads:[~2014-06-10 18:35 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-10 7:03 [Qemu-devel] [PATCH 0/3] dataplane: introduce virtio-blk.iothread property Stefan Hajnoczi
2014-06-10 7:03 ` [Qemu-devel] [PATCH 1/3] virtio-blk: replace x-iothread with iothread link property Stefan Hajnoczi
2014-06-10 18:35 ` Paolo Bonzini [this message]
2014-06-18 11:11 ` Stefan Hajnoczi
2014-06-18 13:01 ` Paolo Bonzini
2014-06-10 7:03 ` [Qemu-devel] [PATCH 2/3] qdev: drop iothread property type Stefan Hajnoczi
2014-06-10 7:03 ` [Qemu-devel] [PATCH 3/3] virtio-blk: remove need for explicit x-data-plane=on option Stefan Hajnoczi
2014-06-10 9:03 ` [Qemu-devel] [PATCH 0/3] dataplane: introduce virtio-blk.iothread property Paolo Bonzini
2014-06-30 13:09 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53974FF7.5010504@redhat.com \
--to=pbonzini@redhat.com \
--cc=afaerber@suse.de \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).