From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:44090)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1WuQtg-0002HB-Rh
	for qemu-devel@nongnu.org; Tue, 10 Jun 2014 14:35:57 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1WuQtX-0000NE-QQ
	for qemu-devel@nongnu.org; Tue, 10 Jun 2014 14:35:48 -0400
Received: from mail-wi0-x230.google.com ([2a00:1450:400c:c05::230]:52214)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1WuQtX-0000N8-Dp
	for qemu-devel@nongnu.org; Tue, 10 Jun 2014 14:35:39 -0400
Received: by mail-wi0-f176.google.com with SMTP id n3so4087419wiv.3
	for <qemu-devel@nongnu.org>; Tue, 10 Jun 2014 11:35:38 -0700 (PDT)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <53974FF7.5010504@redhat.com>
Date: Tue, 10 Jun 2014 20:35:35 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1402383802-14252-1-git-send-email-stefanha@redhat.com>
	<1402383802-14252-2-git-send-email-stefanha@redhat.com>
In-Reply-To: <1402383802-14252-2-git-send-email-stefanha@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 1/3] virtio-blk: replace x-iothread with
 iothread link property
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Hajnoczi <stefanha@redhat.com>, qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>, Andreas Faerber <afaerber@suse.de>

Il 10/06/2014 09:03, Stefan Hajnoczi ha scritto:
> @@ -193,6 +193,8 @@ static void s390_virtio_blk_instance_init(Object *obj)
>      object_property_add_child(obj, "virtio-backend", OBJECT(&dev->vdev), NULL);
>      object_unref(OBJECT(&dev->vdev));
>      qdev_alias_all_properties(DEVICE(&dev->vdev), obj);
> +    object_property_add_alias(obj, "iothread", OBJECT(&dev->vdev),"iothread",
> +                              &error_abort);

Actually this won't work.  Link properties have to have a LinkProperty 
opaque.

The series I posted to add a "resolve" callback for properties can be 
used here, fixing object_property_add_alias to add a "resolve" callback 
to the newly-created property.

My ack for this patch still stands, it's just a matter of patch ordering.

Paolo