From: Paolo Bonzini <pbonzini@redhat.com>
To: Peter Crosthwaite <peter.crosthwaite@xilinx.com>
Cc: "qemu-devel@nongnu.org Developers" <qemu-devel@nongnu.org>,
"Andreas Färber" <afaerber@suse.de>
Subject: Re: [Qemu-devel] [RFC PATCH 09/13] memory: MemoryRegion: QOMify
Date: Wed, 11 Jun 2014 16:48:20 +0200 [thread overview]
Message-ID: <53986C34.3060303@redhat.com> (raw)
In-Reply-To: <CAEgOgz6Z52h+iEXHT1wGxs_9b9Us_xEwkYyZaedTAAszYbGyRw@mail.gmail.com>
Il 11/06/2014 16:32, Peter Crosthwaite ha scritto:
>> > In the end, I believe the conceptual cleanliness of destroy==unparent, and
>> > the removal of 200-odd memory_region_destroy calls, are worth the extra ugly
>> > [0]'s.
>> >
> I think you get to keep the uniqueness though under my latest
> proposal? No tree-wide collision resolution needed. When
> object_property_add_child_array sucessfully sets something to [0] (i
> == 0 iteration), just create an alias without [] at the same time. The
> naming system will behave identically to this patch as-is in all the
> collision cases (i >= 1).
Yes, but then you get duplicates, and some of them are wrong (the ones
without [0] if there is also a [1]).
I think the solution could be to special case names ending with "[*]"
(perhaps straight in object_property_add_child!), and then audit
manually at all the 400+ init calls.
For now I'd rather keep it simple.
Paolo
next prev parent reply other threads:[~2014-06-11 14:48 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-11 12:19 [Qemu-devel] [RFC PATCH 00/13] "Light" memory region QOMification Paolo Bonzini
2014-06-11 12:19 ` [Qemu-devel] [RFC PATCH 01/13] qom: object: Ignore refs/unrefs of NULL Paolo Bonzini
2014-06-11 12:19 ` [Qemu-devel] [RFC PATCH 02/13] qom: object: remove parent pointer when unparenting Paolo Bonzini
2014-06-11 12:19 ` [Qemu-devel] [RFC PATCH 03/13] qom: move unparenting to the child property's release callback Paolo Bonzini
2014-06-11 13:35 ` Peter Crosthwaite
2014-06-11 14:01 ` Paolo Bonzini
2014-06-11 14:10 ` Peter Crosthwaite
2014-06-11 12:19 ` [Qemu-devel] [RFC PATCH 04/13] qom: delete properties before calling instance_finalize Paolo Bonzini
2014-06-11 13:42 ` Peter Crosthwaite
2014-06-11 14:03 ` Paolo Bonzini
2014-06-17 12:29 ` Peter Crosthwaite
2014-06-11 12:19 ` [Qemu-devel] [RFC PATCH 05/13] memory: MemoryRegion: factor out subregion add functionality Paolo Bonzini
2014-06-11 12:19 ` [Qemu-devel] [RFC PATCH 06/13] memory: MemoryRegion: factor out memory region re-adder Paolo Bonzini
2014-06-11 12:19 ` [Qemu-devel] [RFC PATCH 07/13] memory: MemoryRegion: use /machine as default owner Paolo Bonzini
2014-06-17 12:24 ` Peter Crosthwaite
2014-06-11 12:19 ` [Qemu-devel] [RFC PATCH 08/13] memory: MemoryRegion: rename parent to container Paolo Bonzini
2014-06-11 13:46 ` Peter Crosthwaite
2014-06-11 12:19 ` [Qemu-devel] [RFC PATCH 09/13] memory: MemoryRegion: QOMify Paolo Bonzini
2014-06-11 13:12 ` Peter Crosthwaite
2014-06-11 14:15 ` Paolo Bonzini
2014-06-11 14:32 ` Peter Crosthwaite
2014-06-11 14:48 ` Paolo Bonzini [this message]
2014-06-17 12:17 ` Peter Crosthwaite
2014-06-11 12:19 ` [Qemu-devel] [RFC PATCH 10/13] memory: MemoryRegion: replace owner field with QOM parent Paolo Bonzini
2014-06-11 14:03 ` Peter Crosthwaite
2014-06-11 12:19 ` [Qemu-devel] [RFC PATCH 11/13] memory: MemoryRegion: Add container and addr props Paolo Bonzini
2014-06-11 12:19 ` [Qemu-devel] [RFC PATCH 12/13] memory: MemoryRegion: Add may-overlap and priority props Paolo Bonzini
2014-06-11 12:19 ` [Qemu-devel] [RFC PATCH 13/13] memory: MemoryRegion: Add size property Paolo Bonzini
2014-06-17 12:27 ` [Qemu-devel] [RFC PATCH 00/13] "Light" memory region QOMification Peter Crosthwaite
2014-06-17 12:35 ` Paolo Bonzini
2014-06-17 12:51 ` Peter Crosthwaite
2014-06-17 12:57 ` Paolo Bonzini
2014-06-25 9:45 ` Peter Crosthwaite
2014-06-25 9:47 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53986C34.3060303@redhat.com \
--to=pbonzini@redhat.com \
--cc=afaerber@suse.de \
--cc=peter.crosthwaite@xilinx.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).