From: Eric Blake <eblake@redhat.com>
To: Kevin Wolf <kwolf@redhat.com>, qemu-devel@nongnu.org
Cc: armbru@redhat.com, stefanha@redhat.com
Subject: Re: [Qemu-devel] [PATCH 2/9] block: Move bdrv_fill_options() call to bdrv_open()
Date: Wed, 11 Jun 2014 13:31:33 -0600 [thread overview]
Message-ID: <5398AE95.7050703@redhat.com> (raw)
In-Reply-To: <1402495503-4722-3-git-send-email-kwolf@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 952 bytes --]
On 06/11/2014 08:04 AM, Kevin Wolf wrote:
> bs->options now contains the modified version of the options.
>
> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
> ---
> block.c | 26 ++++++++++++++++----------
> 1 file changed, 16 insertions(+), 10 deletions(-)
>
> diff --git a/block.c b/block.c
> index c5707e8..effb3e6 100644
> --- a/block.c
> +++ b/block.c
> @@ -1010,14 +1010,19 @@ free_and_fail:
> * Fills in default options for opening images and converts the legacy
> * filename/flags pair to option QDict entries.
> */
> -static int bdrv_fill_options(QDict **options, const char *filename,
> +static int bdrv_fill_options(QDict **options, const char *filename, int flags,
> Error **errp)
Ah, this fixes one of my findings on 1/9.
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
next prev parent reply other threads:[~2014-06-11 19:31 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-11 14:04 [Qemu-devel] [PATCH 0/9] bdrv_open() cleanups, part 1 Kevin Wolf
2014-06-11 14:04 ` [Qemu-devel] [PATCH 1/9] block: Create bdrv_fill_options() Kevin Wolf
2014-06-11 19:14 ` Eric Blake
2014-06-12 12:08 ` Benoît Canet
2014-06-23 15:30 ` Kevin Wolf
2014-06-23 16:38 ` Benoît Canet
2014-06-11 14:04 ` [Qemu-devel] [PATCH 2/9] block: Move bdrv_fill_options() call to bdrv_open() Kevin Wolf
2014-06-11 19:31 ` Eric Blake [this message]
2014-06-12 12:19 ` Benoît Canet
2014-06-11 14:04 ` [Qemu-devel] [PATCH 3/9] block: Move json: parsing to bdrv_fill_options() Kevin Wolf
2014-06-11 19:35 ` Eric Blake
2014-06-12 12:26 ` Benoît Canet
2014-06-12 13:47 ` Eric Blake
2014-06-11 14:04 ` [Qemu-devel] [PATCH 4/9] block: Always pass driver name through options QDict Kevin Wolf
2014-06-11 19:43 ` Eric Blake
2014-06-12 12:40 ` Benoît Canet
2014-06-11 14:04 ` [Qemu-devel] [PATCH 5/9] block: Use common driver selection code for bdrv_open_file() Kevin Wolf
2014-06-11 20:24 ` Eric Blake
2014-06-12 12:48 ` Benoît Canet
2014-06-11 14:05 ` [Qemu-devel] [PATCH 6/9] block: Inline bdrv_file_open() Kevin Wolf
2014-06-12 12:50 ` Benoît Canet
2014-06-11 14:05 ` [Qemu-devel] [PATCH 7/9] block: Remove second bdrv_open() recursion Kevin Wolf
2014-06-11 14:05 ` [Qemu-devel] [PATCH 8/9] block: Catch backing files assigned to non-COW drivers Kevin Wolf
2014-06-11 14:05 ` [Qemu-devel] [PATCH 9/9] block: Remove a special case for protocols Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5398AE95.7050703@redhat.com \
--to=eblake@redhat.com \
--cc=armbru@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).