From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56265) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WuoFJ-0001AZ-Bj for qemu-devel@nongnu.org; Wed, 11 Jun 2014 15:31:46 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WuoFE-0004cJ-C0 for qemu-devel@nongnu.org; Wed, 11 Jun 2014 15:31:41 -0400 Received: from mx1.redhat.com ([209.132.183.28]:61450) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WuoFE-0004cC-2G for qemu-devel@nongnu.org; Wed, 11 Jun 2014 15:31:36 -0400 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s5BJVYOs012809 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Wed, 11 Jun 2014 15:31:35 -0400 Message-ID: <5398AE95.7050703@redhat.com> Date: Wed, 11 Jun 2014 13:31:33 -0600 From: Eric Blake MIME-Version: 1.0 References: <1402495503-4722-1-git-send-email-kwolf@redhat.com> <1402495503-4722-3-git-send-email-kwolf@redhat.com> In-Reply-To: <1402495503-4722-3-git-send-email-kwolf@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="K0sk5CrHSmDSaBKWR8cBHIttHHUCEHsvO" Subject: Re: [Qemu-devel] [PATCH 2/9] block: Move bdrv_fill_options() call to bdrv_open() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf , qemu-devel@nongnu.org Cc: armbru@redhat.com, stefanha@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --K0sk5CrHSmDSaBKWR8cBHIttHHUCEHsvO Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 06/11/2014 08:04 AM, Kevin Wolf wrote: > bs->options now contains the modified version of the options. >=20 > Signed-off-by: Kevin Wolf > --- > block.c | 26 ++++++++++++++++---------- > 1 file changed, 16 insertions(+), 10 deletions(-) >=20 > diff --git a/block.c b/block.c > index c5707e8..effb3e6 100644 > --- a/block.c > +++ b/block.c > @@ -1010,14 +1010,19 @@ free_and_fail: > * Fills in default options for opening images and converts the legacy= > * filename/flags pair to option QDict entries. > */ > -static int bdrv_fill_options(QDict **options, const char *filename, > +static int bdrv_fill_options(QDict **options, const char *filename, in= t flags, > Error **errp) Ah, this fixes one of my findings on 1/9. Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --K0sk5CrHSmDSaBKWR8cBHIttHHUCEHsvO Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJTmK6VAAoJEKeha0olJ0NqSmMH/33XbP/UYZts5LA+mlzYIPmX jpKvpzB7NJrCMUYplZlIVmgN6oCNN1TorK3qDfzSe5bHoZvNSKp96UkA4+ljDTgk VDnbVLV5EFs+IGcPdoRS3QtFymlQn1SDB2dBHH9c6bgJElV9Ra1SXpDCuoetAdBb 4JpOgPN6+zYYFFyXS9y0VV9Suzzc3kFYGGZ5jW894mRPXi99rDQCHVOGX3gWzRb/ 0JRwhDYx4Fdc4LROv7Q1BtmjszyD0KHqvXaPwFUC6faJRNVwcXMmTYpFLW4pltR6 KsbBX4FnJ1BBIPMjr4kKjSEMDBEu7tXD9iV9n1Wxy+lzMQYt5EKdTHfRUjb7trE= =Q1Fw -----END PGP SIGNATURE----- --K0sk5CrHSmDSaBKWR8cBHIttHHUCEHsvO--