From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52181) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wv0UB-0004yd-Cy for qemu-devel@nongnu.org; Thu, 12 Jun 2014 04:35:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Wv0U3-0004TD-Tk for qemu-devel@nongnu.org; Thu, 12 Jun 2014 04:35:51 -0400 Received: from mail-pd0-f170.google.com ([209.85.192.170]:43556) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wv0U3-0004Sq-Nx for qemu-devel@nongnu.org; Thu, 12 Jun 2014 04:35:43 -0400 Received: by mail-pd0-f170.google.com with SMTP id g10so740145pdj.15 for ; Thu, 12 Jun 2014 01:35:41 -0700 (PDT) Message-ID: <53996657.1020102@ozlabs.ru> Date: Thu, 12 Jun 2014 18:35:35 +1000 From: Alexey Kardashevskiy MIME-Version: 1.0 References: <1402506183-29736-1-git-send-email-aik@ozlabs.ru> <1402506183-29736-3-git-send-email-aik@ozlabs.ru> <53989212.6060603@redhat.com> <5398EF94.5050407@ozlabs.ru> <539959F9.8040602@redhat.com> In-Reply-To: <539959F9.8040602@redhat.com> Content-Type: text/plain; charset=KOI8-R Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v6 2/4] target-s390x: Migrate to new NMI interface List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini , qemu-devel@nongnu.org Cc: Peter Maydell , Stefan Hajnoczi , Alexander Graf , Markus Armbruster , qemu-ppc@nongnu.org, Alex Bligh , Cornelia Huck , Luiz Capitulino , Richard Henderson On 06/12/2014 05:42 PM, Paolo Bonzini wrote: > Il 12/06/2014 02:08, Alexey Kardashevskiy ha scritto: >>> > I would use the /machine object itself, not an extra object. Otherwise >>> > this looks good. >> >> "/machine" object is "machine" parameter from s390_init()? How do I add an >> interface to it? Create a machine class as it is done by >> spapr_machine_info? I am not that familiar with QOM and definitely miss >> something. > > No, you are not. :) You need exactly to do what was done for sPAPR. Note > that s390 has two machine classes. 2 machines... Heh. If only. Here is x86: qemu_register_machine(&pc_i440fx_machine_v2_1); qemu_register_machine(&pc_i440fx_machine_v2_0); qemu_register_machine(&pc_i440fx_machine_v1_7); qemu_register_machine(&pc_i440fx_machine_v1_6); qemu_register_machine(&pc_i440fx_machine_v1_5); qemu_register_machine(&pc_i440fx_machine_v1_4); qemu_register_machine(&pc_machine_v1_3); qemu_register_machine(&pc_machine_v1_2); qemu_register_machine(&pc_machine_v1_1); qemu_register_machine(&pc_machine_v1_0); qemu_register_machine(&pc_machine_v0_15); qemu_register_machine(&pc_machine_v0_14); qemu_register_machine(&pc_machine_v0_13); qemu_register_machine(&pc_machine_v0_12); qemu_register_machine(&pc_machine_v0_11); qemu_register_machine(&pc_machine_v0_10); qemu_register_machine(&isapc_machine); qemu_register_machine(&xenfv_machine); qemu_register_machine(&pc_q35_machine_v2_1); qemu_register_machine(&pc_q35_machine_v2_0); qemu_register_machine(&pc_q35_machine_v1_7); qemu_register_machine(&pc_q35_machine_v1_6); qemu_register_machine(&pc_q35_machine_v1_5); qemu_register_machine(&pc_q35_machine_v1_4); These all are QEMUMachine's, not TYPE_MACHINE so I'll need to convert them too. Converting SPAPR's QEMUMachine took several patches, 958db90cd54823c33345000c995453a8c9b7a005 "machine: Remove QEMUMachine indirection from MachineClass" was quite big. If you tell me to convert them all, ok, I'll do it :) -- Alexey