From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54078) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wv0a5-0004Gr-UB for qemu-devel@nongnu.org; Thu, 12 Jun 2014 04:42:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Wv0Zy-0006ek-Da for qemu-devel@nongnu.org; Thu, 12 Jun 2014 04:41:57 -0400 Message-ID: <539967B8.6020109@redhat.com> Date: Thu, 12 Jun 2014 10:41:28 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1402506183-29736-1-git-send-email-aik@ozlabs.ru> <1402506183-29736-3-git-send-email-aik@ozlabs.ru> <53989212.6060603@redhat.com> <5398EF94.5050407@ozlabs.ru> <539959F9.8040602@redhat.com> <53996657.1020102@ozlabs.ru> In-Reply-To: <53996657.1020102@ozlabs.ru> Content-Type: text/plain; charset=KOI8-R; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v6 2/4] target-s390x: Migrate to new NMI interface List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexey Kardashevskiy , qemu-devel@nongnu.org Cc: Peter Maydell , Stefan Hajnoczi , Alexander Graf , Markus Armbruster , qemu-ppc@nongnu.org, Alex Bligh , Cornelia Huck , Luiz Capitulino , Richard Henderson Il 12/06/2014 10:35, Alexey Kardashevskiy ha scritto: > On 06/12/2014 05:42 PM, Paolo Bonzini wrote: >> Il 12/06/2014 02:08, Alexey Kardashevskiy ha scritto: >>>>> I would use the /machine object itself, not an extra object. Otherwise >>>>> this looks good. >>> >>> "/machine" object is "machine" parameter from s390_init()? How do I add an >>> interface to it? Create a machine class as it is done by >>> spapr_machine_info? I am not that familiar with QOM and definitely miss >>> something. >> >> No, you are not. :) You need exactly to do what was done for sPAPR. Note >> that s390 has two machine classes. > > 2 machines... Heh. If only. Here is x86: > > qemu_register_machine(&pc_i440fx_machine_v2_1); > qemu_register_machine(&pc_i440fx_machine_v2_0); > qemu_register_machine(&pc_i440fx_machine_v1_7); > qemu_register_machine(&pc_i440fx_machine_v1_6); > qemu_register_machine(&pc_i440fx_machine_v1_5); > qemu_register_machine(&pc_i440fx_machine_v1_4); > qemu_register_machine(&pc_machine_v1_3); > qemu_register_machine(&pc_machine_v1_2); > qemu_register_machine(&pc_machine_v1_1); > qemu_register_machine(&pc_machine_v1_0); > qemu_register_machine(&pc_machine_v0_15); > qemu_register_machine(&pc_machine_v0_14); > qemu_register_machine(&pc_machine_v0_13); > qemu_register_machine(&pc_machine_v0_12); > qemu_register_machine(&pc_machine_v0_11); > qemu_register_machine(&pc_machine_v0_10); > qemu_register_machine(&isapc_machine); > qemu_register_machine(&xenfv_machine); > > > qemu_register_machine(&pc_q35_machine_v2_1); > qemu_register_machine(&pc_q35_machine_v2_0); > qemu_register_machine(&pc_q35_machine_v1_7); > qemu_register_machine(&pc_q35_machine_v1_6); > qemu_register_machine(&pc_q35_machine_v1_5); > qemu_register_machine(&pc_q35_machine_v1_4); > > > These all are QEMUMachine's, not TYPE_MACHINE so I'll need to convert them too. There is a patch on the list from Eduardo Habkost to convert them and especially to add a common TYPE_PC_MACHINE superclass. Just do s390 and PPC for now. We'll take care later of x86. Paolo