Re: [Qemu-devel] [PATCH v6 1/4] cpus: Define callback for QEMU "nmi" command

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1873 bytes --]

On 06/11/2014 09:29 PM, Alexey Kardashevskiy wrote:
> On 06/12/2014 11:46 AM, Eric Blake wrote:
>> On 06/11/2014 06:10 PM, Alexey Kardashevskiy wrote:
>>
>>>>> + *  This program is free software; you can redistribute it and/or modify
>>>>> + *  it under the terms of the GNU General Public License as published by
>>>>> + *  the Free Software Foundation; either version 2 of the License,
>>>>> + *  or (at your option) any later version.
>>
>>>>
>>>> For the GPL license to work, there has to be a Copyright line.
>>>
>>> Hm. Ok. include/hw/fw-path-provider.h (where I copied this from) does not
>>> have one and it was ok.
>>
>> Just because there's existing bad practice in the code base doesn't mean
>> new files should perpetuate it :)
> 
> Paolo did that in the first place and if he does it, I assume this is at
> least not "bad" ;)
> 
> Like this? I do not know what should be there, corporation or something or
> just me?

If you are submitting on behalf of an employer, then list your employer;
otherwise listing yourself is just fine.


> 
> --- a/hw/core/nmi.c
> +++ b/hw/core/nmi.c
> @@ -1,6 +1,8 @@
>  /*
>   *  NMI monitor handler class and helpers.
>   *
> + *  Copyright (c) 2014 Alexey Kardashevskiy <aik@ozlabs.ru>
> + *
>   *  This program is free software; you can redistribute it and/or modify
>   *  it under the terms of the GNU General Public License as published by
>   *  the Free Software Foundation; either version 2 of the License,
> 

Yes, that is probably just fine since you are the initial contributor of
the file.  Another option is if your new file is significantly
copy-and-pasted from some other file, then you would preserve whatever
copyright was present in that earlier file.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]