From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39941) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wv5HV-0002tO-Ah for qemu-devel@nongnu.org; Thu, 12 Jun 2014 09:43:10 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Wv5HQ-0003vY-5N for qemu-devel@nongnu.org; Thu, 12 Jun 2014 09:43:05 -0400 Message-ID: <5399AE57.1010004@redhat.com> Date: Thu, 12 Jun 2014 07:42:47 -0600 From: Eric Blake MIME-Version: 1.0 References: <1402506183-29736-1-git-send-email-aik@ozlabs.ru> <1402506183-29736-2-git-send-email-aik@ozlabs.ru> <53989009.1000300@redhat.com> <5398EFF6.7060603@ozlabs.ru> <5399067B.20009@redhat.com> <53991EB5.6010104@ozlabs.ru> In-Reply-To: <53991EB5.6010104@ozlabs.ru> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="aQc34lPOBTr2Ju4MHtVWLFoqwr53KkNsa" Subject: Re: [Qemu-devel] [PATCH v6 1/4] cpus: Define callback for QEMU "nmi" command List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexey Kardashevskiy , qemu-devel@nongnu.org Cc: Peter Maydell , Alex Bligh , Markus Armbruster , Luiz Capitulino , Alexander Graf , qemu-ppc@nongnu.org, Stefan Hajnoczi , Cornelia Huck , Paolo Bonzini , Richard Henderson This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --aQc34lPOBTr2Ju4MHtVWLFoqwr53KkNsa Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 06/11/2014 09:29 PM, Alexey Kardashevskiy wrote: > On 06/12/2014 11:46 AM, Eric Blake wrote: >> On 06/11/2014 06:10 PM, Alexey Kardashevskiy wrote: >> >>>>> + * This program is free software; you can redistribute it and/or = modify >>>>> + * it under the terms of the GNU General Public License as publis= hed by >>>>> + * the Free Software Foundation; either version 2 of the License,= >>>>> + * or (at your option) any later version. >> >>>> >>>> For the GPL license to work, there has to be a Copyright line. >>> >>> Hm. Ok. include/hw/fw-path-provider.h (where I copied this from) does= not >>> have one and it was ok. >> >> Just because there's existing bad practice in the code base doesn't me= an >> new files should perpetuate it :) >=20 > Paolo did that in the first place and if he does it, I assume this is a= t > least not "bad" ;) >=20 > Like this? I do not know what should be there, corporation or something= or > just me? If you are submitting on behalf of an employer, then list your employer; otherwise listing yourself is just fine. >=20 > --- a/hw/core/nmi.c > +++ b/hw/core/nmi.c > @@ -1,6 +1,8 @@ > /* > * NMI monitor handler class and helpers. > * > + * Copyright (c) 2014 Alexey Kardashevskiy > + * > * This program is free software; you can redistribute it and/or modi= fy > * it under the terms of the GNU General Public License as published = by > * the Free Software Foundation; either version 2 of the License, >=20 Yes, that is probably just fine since you are the initial contributor of the file. Another option is if your new file is significantly copy-and-pasted from some other file, then you would preserve whatever copyright was present in that earlier file. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --aQc34lPOBTr2Ju4MHtVWLFoqwr53KkNsa Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJTma5XAAoJEKeha0olJ0NqZv4H/RDWyTtMaCiSSder5mYGF5ms BbxSDGuyIeG99nKCN293E6TafjHdOEZk0ZU4JYlv3X4FWtWRaRiS2Z8JQ+kXb+kc ZaJLD3FJ3byOqYTrpYhOfXemxTyecmMtO7kTvugVfJS64gN73uug8AboFOC7Nrbv HbGfgYajBZUSgBi0ctjgYIo2bZkv8T75oIui6cyBm2jeeOniDURom1bZmhjWJL0U /y6CquOznkNByYPUYPVvUNO3PqwL3XxfPerApVwhNEocHJEOCcG6QtO0FFDKWlgQ 1573uZUBaJXqMzKRnlbw86MDEL5x67Li1dTaU8dcHVu8rr/uCm2GjEpaOdEeLuQ= =jw1m -----END PGP SIGNATURE----- --aQc34lPOBTr2Ju4MHtVWLFoqwr53KkNsa--