From: Eric Blake <eblake@redhat.com>
To: "Benoît Canet" <benoit.canet@irqsave.net>,
"Kevin Wolf" <kwolf@redhat.com>
Cc: qemu-devel@nongnu.org, stefanha@redhat.com, armbru@redhat.com
Subject: Re: [Qemu-devel] [PATCH 3/9] block: Move json: parsing to bdrv_fill_options()
Date: Thu, 12 Jun 2014 07:47:16 -0600 [thread overview]
Message-ID: <5399AF64.1040603@redhat.com> (raw)
In-Reply-To: <20140612122603.GC24528@irqsave.net>
[-- Attachment #1: Type: text/plain, Size: 764 bytes --]
On 06/12/2014 06:26 AM, Benoît Canet wrote:
>> +static QDict *parse_json_filename(const char *filename, Error **errp)
>> +{
>
> I am under the impression that this code move could be avoided by using a function
> prototype: the patch would be less cluttered.
I'm a fan of avoiding function prototypes for static functions when
possible (listing things in topological order is nicer for someone
reading the file for the first time - prototypes only help for recursive
functions), so I'm in favor of keeping the code motion. But splitting
code motion into its own patch rather than mixing it with other changes
is nicer on reviewers.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
next prev parent reply other threads:[~2014-06-12 13:47 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-11 14:04 [Qemu-devel] [PATCH 0/9] bdrv_open() cleanups, part 1 Kevin Wolf
2014-06-11 14:04 ` [Qemu-devel] [PATCH 1/9] block: Create bdrv_fill_options() Kevin Wolf
2014-06-11 19:14 ` Eric Blake
2014-06-12 12:08 ` Benoît Canet
2014-06-23 15:30 ` Kevin Wolf
2014-06-23 16:38 ` Benoît Canet
2014-06-11 14:04 ` [Qemu-devel] [PATCH 2/9] block: Move bdrv_fill_options() call to bdrv_open() Kevin Wolf
2014-06-11 19:31 ` Eric Blake
2014-06-12 12:19 ` Benoît Canet
2014-06-11 14:04 ` [Qemu-devel] [PATCH 3/9] block: Move json: parsing to bdrv_fill_options() Kevin Wolf
2014-06-11 19:35 ` Eric Blake
2014-06-12 12:26 ` Benoît Canet
2014-06-12 13:47 ` Eric Blake [this message]
2014-06-11 14:04 ` [Qemu-devel] [PATCH 4/9] block: Always pass driver name through options QDict Kevin Wolf
2014-06-11 19:43 ` Eric Blake
2014-06-12 12:40 ` Benoît Canet
2014-06-11 14:04 ` [Qemu-devel] [PATCH 5/9] block: Use common driver selection code for bdrv_open_file() Kevin Wolf
2014-06-11 20:24 ` Eric Blake
2014-06-12 12:48 ` Benoît Canet
2014-06-11 14:05 ` [Qemu-devel] [PATCH 6/9] block: Inline bdrv_file_open() Kevin Wolf
2014-06-12 12:50 ` Benoît Canet
2014-06-11 14:05 ` [Qemu-devel] [PATCH 7/9] block: Remove second bdrv_open() recursion Kevin Wolf
2014-06-11 14:05 ` [Qemu-devel] [PATCH 8/9] block: Catch backing files assigned to non-COW drivers Kevin Wolf
2014-06-11 14:05 ` [Qemu-devel] [PATCH 9/9] block: Remove a special case for protocols Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5399AF64.1040603@redhat.com \
--to=eblake@redhat.com \
--cc=armbru@redhat.com \
--cc=benoit.canet@irqsave.net \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).