From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40938) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wv5Li-0004Wm-0V for qemu-devel@nongnu.org; Thu, 12 Jun 2014 09:47:31 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Wv5Lc-0005fC-84 for qemu-devel@nongnu.org; Thu, 12 Jun 2014 09:47:25 -0400 Received: from mx1.redhat.com ([209.132.183.28]:59650) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wv5Lb-0005dr-V4 for qemu-devel@nongnu.org; Thu, 12 Jun 2014 09:47:20 -0400 Message-ID: <5399AF64.1040603@redhat.com> Date: Thu, 12 Jun 2014 07:47:16 -0600 From: Eric Blake MIME-Version: 1.0 References: <1402495503-4722-1-git-send-email-kwolf@redhat.com> <1402495503-4722-4-git-send-email-kwolf@redhat.com> <20140612122603.GC24528@irqsave.net> In-Reply-To: <20140612122603.GC24528@irqsave.net> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="OWOultnRm0VsSGFHtPKPV3BcW3USbClq2" Subject: Re: [Qemu-devel] [PATCH 3/9] block: Move json: parsing to bdrv_fill_options() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?B?QmVub8OudCBDYW5ldA==?= , Kevin Wolf Cc: qemu-devel@nongnu.org, stefanha@redhat.com, armbru@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --OWOultnRm0VsSGFHtPKPV3BcW3USbClq2 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 06/12/2014 06:26 AM, Beno=C3=AEt Canet wrote: >> +static QDict *parse_json_filename(const char *filename, Error **errp)= >> +{ >=20 > I am under the impression that this code move could be avoided by using= a function > prototype: the patch would be less cluttered. I'm a fan of avoiding function prototypes for static functions when possible (listing things in topological order is nicer for someone reading the file for the first time - prototypes only help for recursive functions), so I'm in favor of keeping the code motion. But splitting code motion into its own patch rather than mixing it with other changes is nicer on reviewers. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --OWOultnRm0VsSGFHtPKPV3BcW3USbClq2 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJTma9kAAoJEKeha0olJ0NqaUgH+QFjq2Ehw5GyxCEFQ+tf86bu HGe5qgEXOoIoUHzuFA0VWfLpEI8WFpY1ICB+110OdPeGm0LcZ6TfemSaiqkJig5l cchsV5BZsBcMlH2UTp3lSKqSD4NSTuacDryiQMvS+u3OZvs8mS33hY82YXKAfckF VdauyjTw2yL8/Zf3eXu0/M8LSoc73dStsWAKFcqc5lFxO8jGnqxaAtbhJqgyZlfJ H4HjvHnHwIrIp8i+pYC3j3JqTWDDH5MsvAhR4jj929Gr9WGJhmpgZApQ6KXuO9Tj 4oRugR46l7QxsT9W1WT7rJou4iNDj6iOIekcanx2afXixBllx1yxFhpR2yYsF/M= =W03U -----END PGP SIGNATURE----- --OWOultnRm0VsSGFHtPKPV3BcW3USbClq2--