From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:51091)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1Wv65B-0005Sx-Ro
	for qemu-devel@nongnu.org; Thu, 12 Jun 2014 10:34:34 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1Wv652-0006Rp-OQ
	for qemu-devel@nongnu.org; Thu, 12 Jun 2014 10:34:25 -0400
Received: from mail-qc0-x22d.google.com ([2607:f8b0:400d:c01::22d]:63996)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1Wv652-0006Rj-KA
	for qemu-devel@nongnu.org; Thu, 12 Jun 2014 10:34:16 -0400
Received: by mail-qc0-f173.google.com with SMTP id l6so2018604qcy.18
	for <qemu-devel@nongnu.org>; Thu, 12 Jun 2014 07:34:16 -0700 (PDT)
Sender: Richard Henderson <rth7680@gmail.com>
Message-ID: <5399BA60.3090302@twiddle.net>
Date: Thu, 12 Jun 2014 07:34:08 -0700
From: Richard Henderson <rth@twiddle.net>
MIME-Version: 1.0
References: <1402499992-64851-1-git-send-email-leon.alrae@imgtec.com>
	<1402499992-64851-13-git-send-email-leon.alrae@imgtec.com>
	<53988650.30605@twiddle.net> <5399665D.4020503@imgtec.com>
In-Reply-To: <5399665D.4020503@imgtec.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v2 12/22] target-mips: add ALIGN, DALIGN,
 BITSWAP and DBITSWAP instructions
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Leon Alrae <leon.alrae@imgtec.com>, qemu-devel@nongnu.org
Cc: yongbok.kim@imgtec.com, cristian.cuna@imgtec.com, aurelien@aurel32.net

On 06/12/2014 01:35 AM, Leon Alrae wrote:
> Yes, it clutters the code a bit. However, by looking at the other
> instructions I got the impression that preferable approach is to avoid
> generating unnecessary code if we can. This seems to be sensible so I'm
> trying to stick to it. So in bitswap example I think there is no point
> in calling the helper if we know that the result will be 0.

On the other hand, for certain values of never that exclude conformance testing
software, one will never see r0 as input to bswap.  So it's still a useless
optimization.


r~