From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59031) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WvMhW-0003O4-4a for qemu-devel@nongnu.org; Fri, 13 Jun 2014 04:19:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WvMhO-0000eC-6t for qemu-devel@nongnu.org; Fri, 13 Jun 2014 04:19:06 -0400 Received: from mx1.redhat.com ([209.132.183.28]:16236) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WvMhN-0000dz-Ui for qemu-devel@nongnu.org; Fri, 13 Jun 2014 04:18:58 -0400 Message-ID: <539AB3E4.4090404@redhat.com> Date: Fri, 13 Jun 2014 10:18:44 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <20140612074118.GA19354@redhat.com> <20140612075300.GC3720@G08FNSTD100614.fnst.cn.fujitsu.com> <20140613080301.GC2117@redhat.com> In-Reply-To: <20140613080301.GC2117@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v5 00/16] NUMA series v5 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" , Hu Tao Cc: Yasunori Goto , qemu-devel@nongnu.org, Eduardo Habkost , Igor Mammedov Il 13/06/2014 10:03, Michael S. Tsirkin ha scritto: >>> > > Two points I would like to see addressed before it's going upstream: >>> > > - please validate and test the pci branch >>> > > there have been lots of changes >>> > > - please work to drop the SignedRange: for all >>> > > current purposes existing Range is sufficient, >>> > > instead of a list and sort re-implementation, it is >>> > > better to use g_list_insert_sorted >> > >> > I see. Thanks for your work! > Could you confirm you'll be able to fix these by Monday? > I'd like to send the pull request then. I think SignedRange can be dealt with after the merge. Paolo