From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:32891)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <agraf@suse.de>) id 1WvP42-00084H-04
	for qemu-devel@nongnu.org; Fri, 13 Jun 2014 06:50:36 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <agraf@suse.de>) id 1WvP3v-0008SY-Re
	for qemu-devel@nongnu.org; Fri, 13 Jun 2014 06:50:29 -0400
Message-ID: <539AD76C.6030902@suse.de>
Date: Fri, 13 Jun 2014 12:50:20 +0200
From: Alexander Graf <agraf@suse.de>
MIME-Version: 1.0
References: <1402630619-4408-1-git-send-email-aik@ozlabs.ru>
In-Reply-To: <1402630619-4408-1-git-send-email-aik@ozlabs.ru>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v7 0/4] cpus: Add generic "nmi" monitor
	command support
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alexey Kardashevskiy <aik@ozlabs.ru>, qemu-devel@nongnu.org
Cc: Peter Maydell <peter.maydell@linaro.org>, Luiz Capitulino <lcapitulino@redhat.com>, Christian Borntraeger <borntraeger@de.ibm.com>, qemu-ppc@nongnu.org, Cornelia Huck <cornelia.huck@de.ibm.com>, Paolo Bonzini <pbonzini@redhat.com>, Richard Henderson <rth@twiddle.net>


On 13.06.14 05:36, Alexey Kardashevskiy wrote:
> This adds an "nmi" monitor command handler per CPUs.
> x86, s390 and ppc CPUS are supported.
>
> Please comment. Thanks.

I like it.

Reviewed-by: Alexander Graf <agraf@suse.de>


Alex

>
> Changes:
> v7:
> * fixed typenames, function names, copyrights
> * s390x QOM'ed for later addition of the NMI interface
> * Since none of x86 machines is QOM'ed, postpone migration to new interface for x86
>
> v6:
> * back 5 steps and make it an interface again
>
> v5:
> * added Error** to the callback
> * fixed some comments
>
> v4:
> * now it is not nmi() but nmi_monitor_handler() to avoid confusion
>
> v3:
> * patches reorganized
> * comments from v2 addressed, more details are in individual commit logs
>
> v2:
> * moved from machine interface to CPUClass callback
> * s390 and x86 moved to target-s390/target-i386
> * x86 handler delivers to the current CPU only now
>
>
>
>
> Alexey Kardashevskiy (4):
>    cpus: Define callback for QEMU "nmi" command
>    s390x: Convert QEMUMachine to MachineClass
>    s390x: Migrate to new NMI interface
>    spapr: Add support for new NMI interface
>
>   cpus.c                     | 17 ++--------
>   hmp-commands.hx            |  6 ++--
>   hw/core/Makefile.objs      |  1 +
>   hw/core/nmi.c              | 84 ++++++++++++++++++++++++++++++++++++++++++++++
>   hw/ppc/spapr.c             | 21 ++++++++++++
>   hw/s390x/s390-virtio-ccw.c | 49 ++++++++++++++++++---------
>   hw/s390x/s390-virtio.c     | 59 ++++++++++++++++++++++----------
>   hw/s390x/s390-virtio.h     |  3 ++
>   include/hw/nmi.h           | 49 +++++++++++++++++++++++++++
>   qapi-schema.json           |  4 +--
>   qmp-commands.hx            |  3 +-
>   target-ppc/cpu-qom.h       |  1 +
>   target-ppc/excp_helper.c   |  8 +++++
>   13 files changed, 249 insertions(+), 56 deletions(-)
>   create mode 100644 hw/core/nmi.c
>   create mode 100644 include/hw/nmi.h
>