From: Paolo Bonzini <pbonzini@redhat.com>
To: Sebastian Tanase <sebastian.tanase@openwide.fr>
Cc: kwolf@redhat.com, peter maydell <peter.maydell@linaro.org>,
jeremy rosen <jeremy.rosen@openwide.fr>,
aliguori@amazon.com, wenchaoqemu@gmail.com, quintela@redhat.com,
qemu-devel@nongnu.org, mjt@tls.msk.ru, mst@redhat.com,
stefanha@redhat.com, armbru@redhat.com, lcapitulino@redhat.com,
michael@walle.cc, camille begue <camille.begue@openwide.fr>,
alex@alex.org.uk, crobinso@redhat.com,
pierre lemagourou <pierre.lemagourou@openwide.fr>,
afaerber@suse.de, rth@twiddle.net
Subject: Re: [Qemu-devel] [RFC PATCH V2 5/5] cpu_exec: Print to console if the guest is late
Date: Fri, 13 Jun 2014 14:03:32 +0200 [thread overview]
Message-ID: <539AE894.4010206@redhat.com> (raw)
In-Reply-To: <967163394.17793099.1402660803135.JavaMail.root@openwide.fr>
Il 13/06/2014 14:00, Sebastian Tanase ha scritto:
>> >
>> > Perhaps stop printing the message after the first 50-100 times?
>> >
>> > Paolo
>> >
> Thank you very much for your feedback.
> Maybe adding a monitor command (info drift) would be better ? Then
> the user would not be spammed by printfs.
I think some spamming is okay, as long as it's not going on forever.
Perhaps even 10 times is enough (I'm not going to ask you to introduce a
rate limiting like printk's :)).
Adding this to the monitor can be useful even separately from the stderr
spam. Perhaps you can add the current drift to "info jit" if you feel
it is useful. You are user #0 of the feature, so your guess is better
than mine.
Paolo
next prev parent reply other threads:[~2014-06-13 12:04 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-13 9:40 [Qemu-devel] [RFC PATCH V2 0/5] icount: Implement delay algorithm between guest and host clocks Sebastian Tanase
2014-06-13 9:40 ` [Qemu-devel] [RFC PATCH V2 1/5] icount: Add 'align' and 'icount' options Sebastian Tanase
2014-06-13 10:17 ` Paolo Bonzini
2014-06-13 9:40 ` [Qemu-devel] [RFC PATCH V2 2/5] icount: Make icount_time_shift available everywhere Sebastian Tanase
2014-06-13 9:40 ` [Qemu-devel] [RFC PATCH V2 3/5] cpu_exec: Add sleeping algorithm Sebastian Tanase
2014-06-13 10:27 ` Paolo Bonzini
2014-06-13 9:40 ` [Qemu-devel] [RFC PATCH V2 4/5] icount_warp: Take into account initial offset between clocks Sebastian Tanase
2014-06-13 10:28 ` Paolo Bonzini
2014-06-13 9:40 ` [Qemu-devel] [RFC PATCH V2 5/5] cpu_exec: Print to console if the guest is late Sebastian Tanase
2014-06-13 10:29 ` Paolo Bonzini
2014-06-13 12:00 ` Sebastian Tanase
2014-06-13 12:03 ` Paolo Bonzini [this message]
2014-06-13 10:32 ` [Qemu-devel] [RFC PATCH V2 0/5] icount: Implement delay algorithm between guest and host clocks Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=539AE894.4010206@redhat.com \
--to=pbonzini@redhat.com \
--cc=afaerber@suse.de \
--cc=alex@alex.org.uk \
--cc=aliguori@amazon.com \
--cc=armbru@redhat.com \
--cc=camille.begue@openwide.fr \
--cc=crobinso@redhat.com \
--cc=jeremy.rosen@openwide.fr \
--cc=kwolf@redhat.com \
--cc=lcapitulino@redhat.com \
--cc=michael@walle.cc \
--cc=mjt@tls.msk.ru \
--cc=mst@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=pierre.lemagourou@openwide.fr \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=rth@twiddle.net \
--cc=sebastian.tanase@openwide.fr \
--cc=stefanha@redhat.com \
--cc=wenchaoqemu@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).