From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:51215)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1WvQDC-0004On-Re
	for qemu-devel@nongnu.org; Fri, 13 Jun 2014 08:04:08 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1WvQD3-0003cJ-3s
	for qemu-devel@nongnu.org; Fri, 13 Jun 2014 08:04:02 -0400
Received: from mx1.redhat.com ([209.132.183.28]:30933)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1WvQD2-0003aN-Rc
	for qemu-devel@nongnu.org; Fri, 13 Jun 2014 08:03:53 -0400
Message-ID: <539AE894.4010206@redhat.com>
Date: Fri, 13 Jun 2014 14:03:32 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <967163394.17793099.1402660803135.JavaMail.root@openwide.fr>
In-Reply-To: <967163394.17793099.1402660803135.JavaMail.root@openwide.fr>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [RFC PATCH V2 5/5] cpu_exec: Print to console if
 the guest is late
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Sebastian Tanase <sebastian.tanase@openwide.fr>
Cc: kwolf@redhat.com, peter maydell <peter.maydell@linaro.org>, jeremy rosen <jeremy.rosen@openwide.fr>, aliguori@amazon.com, wenchaoqemu@gmail.com, quintela@redhat.com, qemu-devel@nongnu.org, mjt@tls.msk.ru, mst@redhat.com, stefanha@redhat.com, armbru@redhat.com, lcapitulino@redhat.com, michael@walle.cc, camille begue <camille.begue@openwide.fr>, alex@alex.org.uk, crobinso@redhat.com, pierre lemagourou <pierre.lemagourou@openwide.fr>, afaerber@suse.de, rth@twiddle.net

Il 13/06/2014 14:00, Sebastian Tanase ha scritto:
>> >
>> > Perhaps stop printing the message after the first 50-100 times?
>> >
>> > Paolo
>> >
> Thank you very much for your feedback.
> Maybe adding a monitor command (info drift) would be better ? Then
> the user would not be spammed by printfs.

I think some spamming is okay, as long as it's not going on forever. 
Perhaps even 10 times is enough (I'm not going to ask you to introduce a 
rate limiting like printk's :)).

Adding this to the monitor can be useful even separately from the stderr 
spam.  Perhaps you can add the current drift to "info jit" if you feel 
it is useful.  You are user #0 of the feature, so your guess is better 
than mine.

Paolo