From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33322) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WvSwu-00054S-6h for qemu-devel@nongnu.org; Fri, 13 Jun 2014 10:59:30 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WvSwo-00053W-9b for qemu-devel@nongnu.org; Fri, 13 Jun 2014 10:59:24 -0400 Message-ID: <539B11C3.2080709@suse.de> Date: Fri, 13 Jun 2014 16:59:15 +0200 From: Alexander Graf MIME-Version: 1.0 References: <5398436F.8040409@gmail.com> <53989EDA.5000903@gmail.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [Qemu-ppc] Fwd: Patch: fix to gen_mcrxr() in target-ppc/translate.c List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Sorav Bansal , Tom Musta Cc: qemu-ppc@nongnu.org, qemu-devel@nongnu.org On 12.06.14 05:11, Sorav Bansal wrote: >> Your patch is missing the signoff. > Here is the patch with the signoff. thanks. > > From da0a962a6d14fe699ebb7cc12450c7de9553b66a Mon Sep 17 00:00:00 2001 > From: Sorav Bansal > Date: Wed, 11 Jun 2014 19:49:49 +0530 > Subject: [PATCH] Fixed the translation of the mcrxr ppc instruction Please resend as a proper top level patch (not an inline reply) and with the SoB line as part of the patch description. Also please include a proper description of what the patch does, why it does it and how the old behavior was broken. http://wiki.qemu.org/Contribute/SubmitAPatch Thanks a lot for your time and effort at fixing this issue :) Alex