From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35774) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WvUvD-0005lK-Fa for qemu-devel@nongnu.org; Fri, 13 Jun 2014 13:05:52 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WvUv7-0003P1-FA for qemu-devel@nongnu.org; Fri, 13 Jun 2014 13:05:47 -0400 Received: from mx1.redhat.com ([209.132.183.28]:45745) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WvUv7-0003Og-4O for qemu-devel@nongnu.org; Fri, 13 Jun 2014 13:05:41 -0400 Message-ID: <539B2F60.2060802@redhat.com> Date: Fri, 13 Jun 2014 11:05:36 -0600 From: Eric Blake MIME-Version: 1.0 References: <1401970944-18735-1-git-send-email-wenchaoqemu@gmail.com> <1401970944-18735-5-git-send-email-wenchaoqemu@gmail.com> In-Reply-To: <1401970944-18735-5-git-send-email-wenchaoqemu@gmail.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="EpPegHu5e6R797wDQpc6nlawU7fF8oLgW" Subject: Re: [Qemu-devel] [PATCH V6 04/29] test: add test cases for qapi event List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Wenchao Xia , qemu-devel@nongnu.org Cc: mdroth@linux.vnet.ibm.com, armbru@redhat.com, lcapitulino@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --EpPegHu5e6R797wDQpc6nlawU7fF8oLgW Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 06/05/2014 06:21 AM, Wenchao Xia wrote: > These cases will verify whether the expected qdict is built. >=20 > Signed-off-by: Wenchao Xia > --- > tests/Makefile | 16 ++- > tests/qapi-schema/qapi-schema-test.json | 12 ++ > tests/qapi-schema/qapi-schema-test.out | 10 +- > tests/test-qmp-event.c | 265 +++++++++++++++++++++++= ++++++++ > 4 files changed, 298 insertions(+), 5 deletions(-) > create mode 100644 tests/test-qmp-event.c >=20 > + > + /* Verify that we have timestamp, then remove it to compare other = field */ s/field/fields/ Minor enough to include that as part of your followup patch to the whole series. Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --EpPegHu5e6R797wDQpc6nlawU7fF8oLgW Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJTmy9gAAoJEKeha0olJ0Nqo2oH/i3ZSza7U5wt4eBXwCS5omqR t0sKgd19MZH9ktKaYZifFlh7cUNjH2twRHQ+vsiwdurkaaREq23ALq1U2iEvK1y/ JtIF4v8WODmFu+pMFCw6dVxNyFvzoCkP6xk8DtdPvH3rShN47FIBl7ra/SzaTZGS BU4Lfzk/q5ysQ3TmepSw0s1kXesWOLol6jlzhWkuCIeEgiezgP/dvGdbp0CbElEm 23XmzLutmXf+Czk3kC6i2mNcNEVlVX5sMTFUacDFQSd9qIvvu4lEiEql+Hee52Xp Q3GRfzMYRH+X4TzeGuKgF/jHHjuIGS+jcA0LGf7hj5WanaqxLAxnHvcB+pwQzbs= =pzUX -----END PGP SIGNATURE----- --EpPegHu5e6R797wDQpc6nlawU7fF8oLgW--