From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42342) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WvXfx-0001ii-JX for qemu-devel@nongnu.org; Fri, 13 Jun 2014 16:02:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WvXfp-0004PK-FJ for qemu-devel@nongnu.org; Fri, 13 Jun 2014 16:02:13 -0400 Received: from mx1.redhat.com ([209.132.183.28]:51521) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WvXfp-0004PC-62 for qemu-devel@nongnu.org; Fri, 13 Jun 2014 16:02:05 -0400 Message-ID: <539B58B9.4050101@redhat.com> Date: Fri, 13 Jun 2014 14:02:01 -0600 From: Eric Blake MIME-Version: 1.0 References: <1401970944-18735-1-git-send-email-wenchaoqemu@gmail.com> <1401970944-18735-10-git-send-email-wenchaoqemu@gmail.com> In-Reply-To: <1401970944-18735-10-git-send-email-wenchaoqemu@gmail.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="VUWPOarjmo6cqDN3X6OajxVvkltdPW5QH" Subject: Re: [Qemu-devel] [PATCH V6 09/29] qapi event: convert POWERDOWN List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Wenchao Xia , qemu-devel@nongnu.org Cc: mdroth@linux.vnet.ibm.com, armbru@redhat.com, lcapitulino@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --VUWPOarjmo6cqDN3X6OajxVvkltdPW5QH Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 06/05/2014 06:22 AM, Wenchao Xia wrote: > There is no existing comments for POWERDOWN in doc/qmp/qmp-events.txt, > so no change on it like other conversion patch. Oddly enough, POWERDOWN _is_ documented in docs/qmp/qmp-spec.txt, but that reference doesn't need updating with this conversion. >=20 > Signed-off-by: Wenchao Xia > --- > qapi-event.json | 10 ++++++++++ > vl.c | 2 +- > 2 files changed, 11 insertions(+), 1 deletions(-) > +++ b/vl.c > @@ -1991,7 +1991,7 @@ void qemu_system_shutdown_request(void) > =20 > static void qemu_system_powerdown(void) > { > - monitor_protocol_event(QEVENT_POWERDOWN, NULL); > + qapi_event_send_powerdown(NULL); Modulo my comment in 8/29 on whether we even need an errp argument, Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --VUWPOarjmo6cqDN3X6OajxVvkltdPW5QH Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJTm1i5AAoJEKeha0olJ0NqwtAH/jT6ZD7pKtmQzoXx3LjRw/j6 1gZ1ErEHeinZwLpEXMow+Po96EHwfzlc9qoPA4EvP4npMIxFA3VfrrvEE1VWQgCA cZAJzduyzAaezBgbaTlEW4sHJtVI+uUbczpP45+JjW3cKXSLdwkztTBf3+AcZhi3 +O/OhTcG312x3/NHlXXvdMwyTtilpL/kL22i2Quhrhw7d7Lrtp+4PYhHsSKsHOZA S4CWK+06OPkXek9vuYFQl5Hkw6uxWz9GWg9di+Oxl5BEzVk4NgjyFRZkLR4GQCDD HF3WGU2jshsGBRkVpqwUtRqllvVz1sRDGvSiYfYSJ63IeOWeS2CukNC/mHHrf6w= =T1X/ -----END PGP SIGNATURE----- --VUWPOarjmo6cqDN3X6OajxVvkltdPW5QH--