From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44602) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WvaZ4-0005A1-Jz for qemu-devel@nongnu.org; Fri, 13 Jun 2014 19:07:23 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WvaYy-0000r2-Ld for qemu-devel@nongnu.org; Fri, 13 Jun 2014 19:07:18 -0400 Received: from mx1.redhat.com ([209.132.183.28]:34656) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WvaYy-0000qe-Cu for qemu-devel@nongnu.org; Fri, 13 Jun 2014 19:07:12 -0400 Message-ID: <539B8418.40402@redhat.com> Date: Sat, 14 Jun 2014 01:07:04 +0200 From: Max Reitz MIME-Version: 1.0 References: <1402493053-13787-1-git-send-email-benoit.canet@irqsave.net> <1402493053-13787-2-git-send-email-benoit.canet@irqsave.net> In-Reply-To: <1402493053-13787-2-git-send-email-benoit.canet@irqsave.net> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v9 1/4] quorum: Add the rewrite-corrupted parameter to quorum List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?ISO-8859-1?Q?Beno=EEt_Canet?= , qemu-devel@nongnu.org Cc: kwolf@redhat.com, Benoit Canet , stefanha@redhat.com On 11.06.2014 15:24, Beno=EEt Canet wrote: > On read operations when this parameter is set and some replicas are cor= rupted > while quorum can be reached quorum will proceed to rewrite the correct = version > of the data to fix the corrupted replicas. > > This will shine with SSD where the FTL will remap the same block at ano= ther > place on rewrite. > > Signed-off-by: Benoit Canet > --- > block/quorum.c | 97 +++++++++++++++++++++++++++++++++++++= ++++++--- > qapi/block-core.json | 5 ++- > tests/qemu-iotests/081 | 15 ++++++- > tests/qemu-iotests/081.out | 10 +++++ > 4 files changed, 119 insertions(+), 8 deletions(-) Reviewed-by: Max Reitz