From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:35496)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1WwB0C-0007D0-Nj
	for qemu-devel@nongnu.org; Sun, 15 Jun 2014 10:01:53 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1WwB03-0006SO-Me
	for qemu-devel@nongnu.org; Sun, 15 Jun 2014 10:01:44 -0400
Received: from mail-wi0-x22b.google.com ([2a00:1450:400c:c05::22b]:51832)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1WwB03-0006Rz-GD
	for qemu-devel@nongnu.org; Sun, 15 Jun 2014 10:01:35 -0400
Received: by mail-wi0-f171.google.com with SMTP id n15so2841272wiw.4
	for <qemu-devel@nongnu.org>; Sun, 15 Jun 2014 07:01:34 -0700 (PDT)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <539DA73A.7040002@redhat.com>
Date: Sun, 15 Jun 2014 16:01:30 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1401970944-18735-1-git-send-email-wenchaoqemu@gmail.com>	<1401970944-18735-17-git-send-email-wenchaoqemu@gmail.com>	<539B6CD3.90905@redhat.com>
	<539CEB04.9030307@gmail.com>
In-Reply-To: <539CEB04.9030307@gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH V6 16/29] qapi event: convert RTC_CHANGE
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Wenchao Xia <wenchaoqemu@gmail.com>, Eric Blake <eblake@redhat.com>, qemu-devel@nongnu.org
Cc: lcapitulino@redhat.com, mdroth@linux.vnet.ibm.com, armbru@redhat.com

Il 15/06/2014 02:38, Wenchao Xia ha scritto:
>>
>> Once again, all callers of qapi_event_send_rtc_change() are passing a
>> NULL errp to silently ignore errors; and I just audited that no errors
>> happen anyways.
>>
>
>   Fixing it.

No, please don't.  I prefer the way you did it in v6.

Paolo