From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42660) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WwSLw-0007gl-6E for qemu-devel@nongnu.org; Mon, 16 Jun 2014 04:33:26 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WwSLp-000428-Up for qemu-devel@nongnu.org; Mon, 16 Jun 2014 04:33:20 -0400 Received: from mail-pa0-f47.google.com ([209.85.220.47]:55584) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WwSLp-00041B-Op for qemu-devel@nongnu.org; Mon, 16 Jun 2014 04:33:13 -0400 Received: by mail-pa0-f47.google.com with SMTP id kq14so1071148pab.6 for ; Mon, 16 Jun 2014 01:33:13 -0700 (PDT) Message-ID: <539EABC2.2010307@ozlabs.ru> Date: Mon, 16 Jun 2014 18:33:06 +1000 From: Alexey Kardashevskiy MIME-Version: 1.0 References: <1402630619-4408-1-git-send-email-aik@ozlabs.ru> <1402630619-4408-4-git-send-email-aik@ozlabs.ru> <20140613080011.7048ce6c.cornelia.huck@de.ibm.com> <539BB66E.10408@ozlabs.ru> <20140616091606.2343cc08.cornelia.huck@de.ibm.com> In-Reply-To: <20140616091606.2343cc08.cornelia.huck@de.ibm.com> Content-Type: text/plain; charset=KOI8-R Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v7 3/4] s390x: Migrate to new NMI interface List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexander Graf Cc: Peter Maydell , qemu-devel@nongnu.org, Luiz Capitulino , Christian Borntraeger , qemu-ppc@nongnu.org, Cornelia Huck , Paolo Bonzini , Richard Henderson On 06/16/2014 05:16 PM, Cornelia Huck wrote: > On Sat, 14 Jun 2014 12:41:50 +1000 > Alexey Kardashevskiy wrote: > >> On 06/13/2014 04:00 PM, Cornelia Huck wrote: >>> On Fri, 13 Jun 2014 13:36:58 +1000 >>> Alexey Kardashevskiy wrote: >>> >>>> This implements an NMI interface for s390 and s390-ccw machines. >>>> >>>> This removes #ifdef s390 branch in qmp_inject_nmi so new s390's >>>> nmi_monitor_handler() callback is going to be used for NMI. >>>> >>>> Since nmi_monitor_handler()-calling code is platform independent, >>>> CPUState::cpu_index is used instead of S390CPU::env.cpu_num. >>>> There should not be any change in behaviour as both @cpu_index and >>>> @cpu_num are global CPU numbers. >>>> >>>> Also, s390_cpu_restart() takes care of preforming operations in >>>> the specific CPU thread so no extra measure is required here either. >>> >>> I find this paragraph a bit confusing; I'd just remove it. >> >> Besides bad english (please feel free to adjust it), what else is confusing >> here? I put it there because the spapr patch makes use of >> async_run_on_cpu() and maintainers may ask why I do not do the same for >> other platforms. This way I hoped I could reduce number of versions to post :) > > What about > > "Note that s390_cpu_restart() already takes care of the specified cpu, > so we don't need to schedule via async_run_on_cpu()." I fail to see how exactly this is better or different but ok :) Alex, should I repost it with Cornelia's suggestion? What should happen next to this patchset? Who is supposed to pick it up? Thanks. >> >>> >>>> >>>> Since the only error s390_cpu_restart() can return is ENOSYS, convert >>>> it to QERR_UNSUPPORTED. >>>> >>>> Signed-off-by: Alexey Kardashevskiy >>>> --- >>>> Changes: >>>> v7: >>>> * since now s390' are QOM'ed, add interface to them and do not create >>>> new object >>>> >>>> v6: >>>> * supported NMI interface >>>> >>>> v5: >>>> * added ENOSYS -> QERR_UNSUPPORTED, qapi/qmp/qerror.h was added for this >>>> >>>> v4: >>>> * s/\/nmi_monitor_handler/ >>>> >>>> v3: >>>> * now contains both old code removal and new code insertion, easier to >>>> track changes >>>> >>>> Conflicts: >>>> hw/s390x/s390-virtio.c >>>> --- >>>> cpus.c | 14 -------------- >>>> hw/s390x/s390-virtio-ccw.c | 6 ++++++ >>>> hw/s390x/s390-virtio.c | 15 +++++++++++++++ >>>> hw/s390x/s390-virtio.h | 3 +++ >>>> 4 files changed, 24 insertions(+), 14 deletions(-) >>>> >>> Reviewed-by: Cornelia Huck >>> >> >> > -- Alexey