From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37691) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WwXhb-0002yq-Jr for qemu-devel@nongnu.org; Mon, 16 Jun 2014 10:16:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WwXhW-0004uO-M7 for qemu-devel@nongnu.org; Mon, 16 Jun 2014 10:16:03 -0400 Received: from mx1.redhat.com ([209.132.183.28]:57994) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WwXhW-0004uG-D1 for qemu-devel@nongnu.org; Mon, 16 Jun 2014 10:15:58 -0400 Message-ID: <539EFC1A.2040701@redhat.com> Date: Mon, 16 Jun 2014 08:15:54 -0600 From: Eric Blake MIME-Version: 1.0 References: <781eb304e07fb4a333e76cea68958a978bb0bfa3.1402683788.git.jcody@redhat.com> <20140616141041.GA12177@irqsave.net> In-Reply-To: <20140616141041.GA12177@irqsave.net> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="RUVdg6n7Je2xQELgroHslnGhDoSKPOFt8" Subject: Re: [Qemu-devel] [PATCH v5 01/10] block: Auto-generate node_names for each BDS entry List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?B?QmVub8OudCBDYW5ldA==?= , Jeff Cody Cc: kwolf@redhat.com, pkrempa@redhat.com, famz@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --RUVdg6n7Je2xQELgroHslnGhDoSKPOFt8 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 06/16/2014 08:10 AM, Beno=C3=AEt Canet wrote: >> The prefix is to aid in identifying it as a qemu-generated name, the >> numeric portion is to guarantee uniqueness in a given qemu session, an= d >> the random characters are to further avoid any accidental collisions >> with user-specified node-names. >=20 > if the __qemu## determined a different name space no collision resoluti= on would be > needed. >=20 > Also Eric you must take care that these node name does not ends up in l= ibvirt > XML since a new qemu process can generate a new different set of node n= ame. Correct. Either libvirt will always generate its own node names (and the presence of a qemu-generated name is a bug in libvirt), or libvirt will query node-names as it runs, and clear them out when the qemu process goes away. It will NOT expose qemu names to user-visible XML (although it should be safe to save the qemu names to internal-only XML used to cache results across libvirtd restarts while still communicating to the same qemu process). --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --RUVdg6n7Je2xQELgroHslnGhDoSKPOFt8 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJTnvwaAAoJEKeha0olJ0NqF3QIAIPVkPGtsksyRHFuS+//v14w xjKHS7AQFV5HE6zEXal0licM06KZsHOiq3Tf8xhU+PH3ednk9/OBG4SJA5IaNSUl h75ivxiEa4E2qVTjOAZqdlZryEnZ6M3YyA7YC/qrnyH6BQm9uAM4nz94YUQHCUdH eCaOT3E1wKA5XXIYuLHu4vSzhgji5Jc6LKYkVZgpZL0rPJ6hZgeh1rtpyHV+F7Kf jPRU0C3rzoDexS0qgctaVwH90vJs6bk5iUzRHHP2c2DQms4qeZunxpG21AerlD2+ aDeNEM8PgoiQtBQIYrsl03tLn6j5G4JXW5jvXvNS6ogbxaSeNdHpSqPLCTNf6l4= =ibar -----END PGP SIGNATURE----- --RUVdg6n7Je2xQELgroHslnGhDoSKPOFt8--