qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Eric Blake <eblake@redhat.com>
To: Igor Mammedov <imammedo@redhat.com>, qemu-devel@nongnu.org
Cc: vasilis.liaskovitis@profitbricks.com, lcapitulino@redhat.com,
	pkrempa@redhat.com, armbru@redhat.com, mst@redhat.com
Subject: Re: [Qemu-devel] [PATCH 2/5] acpi: introduce TYPE_ACPI_DEVICE_IF interface
Date: Mon, 16 Jun 2014 09:32:18 -0600	[thread overview]
Message-ID: <539F0E02.9030502@redhat.com> (raw)
In-Reply-To: <1401978968-7733-3-git-send-email-imammedo@redhat.com>

[-- Attachment #1: Type: text/plain, Size: 2383 bytes --]

On 06/05/2014 08:36 AM, Igor Mammedov wrote:
> ... it will be used to abstract generic ACPI bits from
> device that implements ACPI interface.
> 
> ACPIOSTInfo type is used for passing-through raw _OST
> event/status codes reported by guest OS to a management
> layer. It lets management tools to interpret values

s/to //

> as specified by ACPI spec if it interested in it.

s/if it/if it is/

> 
> QEMU doesn't encode these values as enum, since it
> doesn't need to handle them and it allows interface
> to scale well without any changes in QEMU while guest
> OS and management evolves in time.
> 
> Signed-off-by: Igor Mammedov <imammedo@redhat.com>
> ---
> v2:
>  - fix doc comments, describe not described fields
>  - add slot-type field with DIMM type for now, which later
>    we could extend to PCI slots and probably to CPUs
>  - extend commit message describing why source/status
>    are raw integers vs enum.
> ---
>  hw/acpi/Makefile.objs                |    1 +
>  hw/acpi/acpi_interface.c             |   15 ++++++++++++
>  include/hw/acpi/acpi_dev_interface.h |   43 ++++++++++++++++++++++++++++++++++
>  qapi-schema.json                     |   31 ++++++++++++++++++++++++
>  4 files changed, 90 insertions(+), 0 deletions(-)
>  create mode 100644 hw/acpi/acpi_interface.c
>  create mode 100644 include/hw/acpi/acpi_dev_interface.h
> 

> +## @ACPIOSTInfo
> +#
> +# OSPM Status Indication for a device
> +# For description of possible values of @source and @status fields
> +# see "_OST (OSPM Status Indication)" chapter of ACPI5.0 spec.
> +#
> +# @device: device ID accossiated with slot

s/accossiated/associated/

Missing #optional annotation

> +#
> +# @slot: slot ID, unique per slot of a given @slot-type
> +#
> +# @slot-type: type of the slot
> +#
> +# @source: an integer containing the source event
> +#
> +# @status: an integer containing the status code
> +#
> +# Since: 2.1
> +##
> +{ 'type': 'ACPIOSTInfo',
> +  'data'  : { '*device': 'str',
> +              'slot': 'str',
> +              'slot-type': 'ACPISlotType',
> +              'source': 'int',
> +              'status': 'int' } }
> 

Fix the docs, and you can add:
Reviewed-by: Eric Blake <eblake@redhat.com>

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]

  reply	other threads:[~2014-06-16 15:32 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-05 14:36 [Qemu-devel] [PATCH 0/5] ACPI memory hotplug: QMP interfaces Igor Mammedov
2014-06-05 14:36 ` [Qemu-devel] [PATCH 1/5] qmp: add query-memory-devices command Igor Mammedov
2014-06-16 15:21   ` Eric Blake
2014-06-05 14:36 ` [Qemu-devel] [PATCH 2/5] acpi: introduce TYPE_ACPI_DEVICE_IF interface Igor Mammedov
2014-06-16 15:32   ` Eric Blake [this message]
2014-06-05 14:36 ` [Qemu-devel] [PATCH 3/5] acpi: implement ospm_status() method for PIIX4/ICH9_LPC devices Igor Mammedov
2014-06-16 16:14   ` Eric Blake
2014-06-16 16:42     ` Igor Mammedov
2014-06-05 14:36 ` [Qemu-devel] [PATCH 4/5] qmp: add query-acpi-ospm-status command Igor Mammedov
2014-06-16 16:19   ` Eric Blake
2014-06-05 14:36 ` [Qemu-devel] [PATCH 5/5] qmp: add ACPI_DEVICE_OST event handling Igor Mammedov
2014-06-16 16:25   ` Eric Blake
2014-06-16 15:03 ` [Qemu-devel] [PATCH 0/5] ACPI memory hotplug: QMP interfaces Igor Mammedov
2014-06-16 15:30 ` Michael S. Tsirkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=539F0E02.9030502@redhat.com \
    --to=eblake@redhat.com \
    --cc=armbru@redhat.com \
    --cc=imammedo@redhat.com \
    --cc=lcapitulino@redhat.com \
    --cc=mst@redhat.com \
    --cc=pkrempa@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=vasilis.liaskovitis@profitbricks.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).