From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33707) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WwYtX-0000be-VK for qemu-devel@nongnu.org; Mon, 16 Jun 2014 11:32:33 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WwYtS-0008PR-60 for qemu-devel@nongnu.org; Mon, 16 Jun 2014 11:32:27 -0400 Received: from mx1.redhat.com ([209.132.183.28]:42856) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WwYtR-0008PM-U2 for qemu-devel@nongnu.org; Mon, 16 Jun 2014 11:32:22 -0400 Message-ID: <539F0E02.9030502@redhat.com> Date: Mon, 16 Jun 2014 09:32:18 -0600 From: Eric Blake MIME-Version: 1.0 References: <1401978968-7733-1-git-send-email-imammedo@redhat.com> <1401978968-7733-3-git-send-email-imammedo@redhat.com> In-Reply-To: <1401978968-7733-3-git-send-email-imammedo@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="oCwSI5l8TsqTLHGPOSCn9aCSE3WrLExSa" Subject: Re: [Qemu-devel] [PATCH 2/5] acpi: introduce TYPE_ACPI_DEVICE_IF interface List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Igor Mammedov , qemu-devel@nongnu.org Cc: vasilis.liaskovitis@profitbricks.com, lcapitulino@redhat.com, pkrempa@redhat.com, armbru@redhat.com, mst@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --oCwSI5l8TsqTLHGPOSCn9aCSE3WrLExSa Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 06/05/2014 08:36 AM, Igor Mammedov wrote: > ... it will be used to abstract generic ACPI bits from > device that implements ACPI interface. >=20 > ACPIOSTInfo type is used for passing-through raw _OST > event/status codes reported by guest OS to a management > layer. It lets management tools to interpret values s/to // > as specified by ACPI spec if it interested in it. s/if it/if it is/ >=20 > QEMU doesn't encode these values as enum, since it > doesn't need to handle them and it allows interface > to scale well without any changes in QEMU while guest > OS and management evolves in time. >=20 > Signed-off-by: Igor Mammedov > --- > v2: > - fix doc comments, describe not described fields > - add slot-type field with DIMM type for now, which later > we could extend to PCI slots and probably to CPUs > - extend commit message describing why source/status > are raw integers vs enum. > --- > hw/acpi/Makefile.objs | 1 + > hw/acpi/acpi_interface.c | 15 ++++++++++++ > include/hw/acpi/acpi_dev_interface.h | 43 ++++++++++++++++++++++++++= ++++++++ > qapi-schema.json | 31 ++++++++++++++++++++++++ > 4 files changed, 90 insertions(+), 0 deletions(-) > create mode 100644 hw/acpi/acpi_interface.c > create mode 100644 include/hw/acpi/acpi_dev_interface.h >=20 > +## @ACPIOSTInfo > +# > +# OSPM Status Indication for a device > +# For description of possible values of @source and @status fields > +# see "_OST (OSPM Status Indication)" chapter of ACPI5.0 spec. > +# > +# @device: device ID accossiated with slot s/accossiated/associated/ Missing #optional annotation > +# > +# @slot: slot ID, unique per slot of a given @slot-type > +# > +# @slot-type: type of the slot > +# > +# @source: an integer containing the source event > +# > +# @status: an integer containing the status code > +# > +# Since: 2.1 > +## > +{ 'type': 'ACPIOSTInfo', > + 'data' : { '*device': 'str', > + 'slot': 'str', > + 'slot-type': 'ACPISlotType', > + 'source': 'int', > + 'status': 'int' } } >=20 Fix the docs, and you can add: Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --oCwSI5l8TsqTLHGPOSCn9aCSE3WrLExSa Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJTnw4CAAoJEKeha0olJ0NqefcH/3oz+j8QOdOnATY42NrLtY8j vVjgI6AB0xZIEtN5d/uf0Y/5wdyh8eGo3j/TScf0zjuiL5JBd4WWlqspTwKoeV0+ g91Fx8dPY6xJ7a2VhwqsKWS9sH1TikUjoSget6tVmjvOU7IXMICnva9kxWcrpak5 tGGC8Ni7ZDg2wqQ+PWuNRt9uTWFqZNDcThbn88P3iqBCF4AEPU1qZC8D9JNbyBq1 m/kQFLAjwx8s4VypeIjSIf+ZC49fkM4c56gQQtfc8+bm9W7ObTcvLaJpuLFyv1N0 hTfrlEcahedpdIcCvFbcB/QMx51470BgwKLKK4gObtxmcsW9vfhCrXrLozoqamk= =He1m -----END PGP SIGNATURE----- --oCwSI5l8TsqTLHGPOSCn9aCSE3WrLExSa--