From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:38087)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1WwZ7B-00089q-3c
	for qemu-devel@nongnu.org; Mon, 16 Jun 2014 11:46:40 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1WwZ72-0005C1-48
	for qemu-devel@nongnu.org; Mon, 16 Jun 2014 11:46:33 -0400
Received: from mx1.redhat.com ([209.132.183.28]:19936)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1WwZ71-0005Bq-S4
	for qemu-devel@nongnu.org; Mon, 16 Jun 2014 11:46:24 -0400
Message-ID: <539F1147.1000409@redhat.com>
Date: Mon, 16 Jun 2014 17:46:15 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <cover.1402299637.git.hutao@cn.fujitsu.com>
	<6c190c63ca7fe6a1d6d5d0944b23240018d76310.1402299637.git.hutao@cn.fujitsu.com>
	<20140616140817.GA8629@otherpad.lan.raisama.net>
	<539EFC39.4030701@redhat.com> <539EFDDD.6010407@redhat.com>
	<539EFFE9.10608@redhat.com>
	<20140616153955.GC3222@otherpad.lan.raisama.net>
In-Reply-To: <20140616153955.GC3222@otherpad.lan.raisama.net>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [libvirt] [PATCH v4 04/29] NUMA: convert -numa
 option to use OptsVisitor
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eduardo Habkost <ehabkost@redhat.com>
Cc: "Michael S. Tsirkin" <mst@redhat.com>, libvir-list@redhat.com, Hu Tao <hutao@cn.fujitsu.com>, qemu-devel@nongnu.org, Martin Kletzander <mkletzan@redhat.com>, Igor Mammedov <imammedo@redhat.com>

Il 16/06/2014 17:39, Eduardo Habkost ha scritto:
> > No, this is a (backwards-compatible) extension to how the option is parsed.
>
> But numa started appearing on query-command-line-options only after this
> patch got applied. It is not the semantics I would expect from
> query-command-line-options, but it is a hint that we have a QEMU version
> with the new numa option handling code.

Oh, then indeed it's possible.  I had forgotten that -numa was using ad 
hoc parsing code, not QemuOpts.

>> > I suppose with QAPI introspection you could check if the QAPI type for -numa
>> > is defined...
> Does this exist, or is it just an idea?

Amos was working on it.

Paolo