qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Eric Blake <eblake@redhat.com>
To: Igor Mammedov <imammedo@redhat.com>, qemu-devel@nongnu.org
Cc: pkrempa@redhat.com, mst@redhat.com, armbru@redhat.com,
	lcapitulino@redhat.com, vasilis.liaskovitis@profitbricks.com,
	Wenchao Xia <xiawenc@linux.vnet.ibm.com>
Subject: Re: [Qemu-devel] [PATCH 5/5] qmp: add ACPI_DEVICE_OST event handling
Date: Mon, 16 Jun 2014 10:25:55 -0600	[thread overview]
Message-ID: <539F1A93.40701@redhat.com> (raw)
In-Reply-To: <1401978968-7733-6-git-send-email-imammedo@redhat.com>

[-- Attachment #1: Type: text/plain, Size: 1161 bytes --]

On 06/05/2014 08:36 AM, Igor Mammedov wrote:
> emmits event when ACPI OSPM evaluates _OST method

s/emmits/emits/

> of ACPI device.
> 
> Signed-off-by: Igor Mammedov <imammedo@redhat.com>
> ---
> v2:
>  - move event decription at the beginning of file

s/decription/description/ (but typos in the changelog don't matter :)

>    to preserve alphabet ordering in file
>  - fix example json
> ---
>  docs/qmp/qmp-events.txt   |   10 ++++++++++
>  hw/acpi/memory_hotplug.c  |   29 ++++++++++++++++++++++++++++-
>  include/monitor/monitor.h |    1 +
>  monitor.c                 |    1 +
>  4 files changed, 40 insertions(+), 1 deletions(-)

It's a race to see whether this gets merged first, or whether Wenchao's
event-as-QAPI series gets merged first (still waiting for v7 on that
series; v6 was here[1]).  Loser has to rebase :)

[1]https://lists.gnu.org/archive/html/qemu-devel/2014-06/msg01222.html

If this goes in first, and you can fix the typo in the commit message,

Reviewed-by: Eric Blake <eblake@redhat.com>

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]

  reply	other threads:[~2014-06-16 16:26 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-05 14:36 [Qemu-devel] [PATCH 0/5] ACPI memory hotplug: QMP interfaces Igor Mammedov
2014-06-05 14:36 ` [Qemu-devel] [PATCH 1/5] qmp: add query-memory-devices command Igor Mammedov
2014-06-16 15:21   ` Eric Blake
2014-06-05 14:36 ` [Qemu-devel] [PATCH 2/5] acpi: introduce TYPE_ACPI_DEVICE_IF interface Igor Mammedov
2014-06-16 15:32   ` Eric Blake
2014-06-05 14:36 ` [Qemu-devel] [PATCH 3/5] acpi: implement ospm_status() method for PIIX4/ICH9_LPC devices Igor Mammedov
2014-06-16 16:14   ` Eric Blake
2014-06-16 16:42     ` Igor Mammedov
2014-06-05 14:36 ` [Qemu-devel] [PATCH 4/5] qmp: add query-acpi-ospm-status command Igor Mammedov
2014-06-16 16:19   ` Eric Blake
2014-06-05 14:36 ` [Qemu-devel] [PATCH 5/5] qmp: add ACPI_DEVICE_OST event handling Igor Mammedov
2014-06-16 16:25   ` Eric Blake [this message]
2014-06-16 15:03 ` [Qemu-devel] [PATCH 0/5] ACPI memory hotplug: QMP interfaces Igor Mammedov
2014-06-16 15:30 ` Michael S. Tsirkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=539F1A93.40701@redhat.com \
    --to=eblake@redhat.com \
    --cc=armbru@redhat.com \
    --cc=imammedo@redhat.com \
    --cc=lcapitulino@redhat.com \
    --cc=mst@redhat.com \
    --cc=pkrempa@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=vasilis.liaskovitis@profitbricks.com \
    --cc=xiawenc@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).