From: Alexander Graf <agraf@suse.de>
To: "Gabriel L. Somlo" <gsomlo@gmail.com>, qemu-devel@nongnu.org
Cc: pbonzini@redhat.com, romain@dolbeau.org, afaerber@suse.de,
stefanha@redhat.com, mst@redhat.com
Subject: Re: [Qemu-devel] [PATCH v1 0/3] e1000: link auto-negotiation fixes
Date: Tue, 17 Jun 2014 00:35:18 +0200 [thread overview]
Message-ID: <539F7126.6070205@suse.de> (raw)
In-Reply-To: <1402939751-8371-1-git-send-email-somlo@cmu.edu>
On 16.06.14 19:29, Gabriel L. Somlo wrote:
> This series contains a few fixes and improvements in the emulation
> of link auto-negotiation:
>
> - use auto-negotiation when the link is bounced externally (e.g. via
> set_link <foo> down/up on the qemu monitor command line).
>
> - allow mii_tool on linux access to all the phy registers and flags
> it requires in order to report a successfully auto-negotiated link.
>
> - inject LSC interrupt upon successful link auto-negotiation (required
> by stock OS X e1000 driver).
>
> See additional prose following commit logs in 2/3 (making up excuses
> for checkpatch error) and 3/3 (further thoughts on OS X vs. Linux/Windows
> re. auto-negotiation and LSC injection).
Looks very reasonable and straight forward to me.
Reviewed-by: Alexander Graf <agraf@suse.de>
Alex
next prev parent reply other threads:[~2014-06-16 22:35 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-16 17:29 [Qemu-devel] [PATCH v1 0/3] e1000: link auto-negotiation fixes Gabriel L. Somlo
2014-06-16 17:29 ` [Qemu-devel] [PATCH v1 1/3] e1000: emulate auto-negotiation during external link status change Gabriel L. Somlo
2014-06-19 13:51 ` Michael S. Tsirkin
2014-06-16 17:29 ` [Qemu-devel] [PATCH v1 2/3] e1000: improve auto-negotiation reporting via mii-tool Gabriel L. Somlo
2014-06-16 17:29 ` [Qemu-devel] [PATCH v1 3/3] e1000: signal guest on successful link auto-negotiation Gabriel L. Somlo
2014-06-16 22:35 ` Alexander Graf [this message]
2014-06-17 4:31 ` [Qemu-devel] [PATCH v1 0/3] e1000: link auto-negotiation fixes Paolo Bonzini
2014-06-17 6:33 ` Alexander Graf
2014-06-17 8:06 ` Paolo Bonzini
2014-06-17 10:48 ` Michael S. Tsirkin
2014-06-17 10:50 ` Alexander Graf
2014-06-18 10:19 ` Stefan Hajnoczi
2014-06-19 13:54 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=539F7126.6070205@suse.de \
--to=agraf@suse.de \
--cc=afaerber@suse.de \
--cc=gsomlo@gmail.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=romain@dolbeau.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).