From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35145) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WwfUt-0006Uv-57 for qemu-devel@nongnu.org; Mon, 16 Jun 2014 18:35:33 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WwfUm-0004XK-4R for qemu-devel@nongnu.org; Mon, 16 Jun 2014 18:35:27 -0400 Received: from cantor2.suse.de ([195.135.220.15]:48825 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WwfUl-0004XA-U4 for qemu-devel@nongnu.org; Mon, 16 Jun 2014 18:35:20 -0400 Message-ID: <539F7126.6070205@suse.de> Date: Tue, 17 Jun 2014 00:35:18 +0200 From: Alexander Graf MIME-Version: 1.0 References: <1402939751-8371-1-git-send-email-somlo@cmu.edu> In-Reply-To: <1402939751-8371-1-git-send-email-somlo@cmu.edu> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v1 0/3] e1000: link auto-negotiation fixes List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Gabriel L. Somlo" , qemu-devel@nongnu.org Cc: pbonzini@redhat.com, romain@dolbeau.org, afaerber@suse.de, stefanha@redhat.com, mst@redhat.com On 16.06.14 19:29, Gabriel L. Somlo wrote: > This series contains a few fixes and improvements in the emulation > of link auto-negotiation: > > - use auto-negotiation when the link is bounced externally (e.g. via > set_link down/up on the qemu monitor command line). > > - allow mii_tool on linux access to all the phy registers and flags > it requires in order to report a successfully auto-negotiated link. > > - inject LSC interrupt upon successful link auto-negotiation (required > by stock OS X e1000 driver). > > See additional prose following commit logs in 2/3 (making up excuses > for checkpatch error) and 3/3 (further thoughts on OS X vs. Linux/Windows > re. auto-negotiation and LSC injection). Looks very reasonable and straight forward to me. Reviewed-by: Alexander Graf Alex