From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39448) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WwfmG-00026E-Aa for qemu-devel@nongnu.org; Mon, 16 Jun 2014 18:53:29 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WwfmB-0001tB-92 for qemu-devel@nongnu.org; Mon, 16 Jun 2014 18:53:24 -0400 Received: from mx1.redhat.com ([209.132.183.28]:58295) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WwfmB-0001t6-0A for qemu-devel@nongnu.org; Mon, 16 Jun 2014 18:53:19 -0400 Message-ID: <539F7559.4020600@redhat.com> Date: Mon, 16 Jun 2014 16:53:13 -0600 From: Eric Blake MIME-Version: 1.0 References: <1401970944-18735-1-git-send-email-wenchaoqemu@gmail.com> <1401970944-18735-22-git-send-email-wenchaoqemu@gmail.com> In-Reply-To: <1401970944-18735-22-git-send-email-wenchaoqemu@gmail.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="cBSHaeLX28xRe7R6iDrwMr9x7n7hTOQIN" Subject: Re: [Qemu-devel] [PATCH V6 21/29] qapi event: convert BLOCK_IMAGE_CORRUPTED List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Wenchao Xia , qemu-devel@nongnu.org Cc: mdroth@linux.vnet.ibm.com, armbru@redhat.com, lcapitulino@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --cBSHaeLX28xRe7R6iDrwMr9x7n7hTOQIN Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 06/05/2014 06:22 AM, Wenchao Xia wrote: > Signed-off-by: Wenchao Xia > --- > block/qcow2-refcount.c | 14 ++++++++------ > docs/qmp/qmp-events.txt | 22 ---------------------- > qapi-event.json | 22 ++++++++++++++++++++++ > 3 files changed, 30 insertions(+), 28 deletions(-) >=20 > -- "device": Device name (json-string) > -- "msg": Informative message (e.g., reason for the corruption) (jso= n-string) > -- "offset": If the corruption resulted from an image access, this is t= he access > - offset into the image (json-int) > -- "size": If the corruption resulted from an image access, this is t= he access > - size (json-int) > - > -Example: > - > -{ "event": "BLOCK_IMAGE_CORRUPTED", > - "data": { "device": "ide0-hd0", > - "msg": "Prevented active L1 table overwrite", "offset": 196608= , The old docs didn't make it clear... > +# > +# @msg: informative message, for example, reason for the corruption =2E..but the new docs should mention that msg is for human consumption an= d should not be parsed by machine as it is not guaranteed to be stable --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --cBSHaeLX28xRe7R6iDrwMr9x7n7hTOQIN Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJTn3VZAAoJEKeha0olJ0Nqm6EIAK8IELRi96B+hEJp0FmXYA4U 5a9K0BfGmfj2DcYbKkgMvAuXUUzG/ntQA2GafGeSvyq16AAMAKuqSXq63JpIsGt4 0laaoFx/Gqx5DnARk0iwAb3tP9qreejH/tOG6YQE4WIIcwM0SPh9CbjHmMgqmMCZ zxCHCwum7GwqCiHbmc3p6vd0MyEBy43mfNtzePqTa+OABp1GHEarxbC0ehue4111 IavAMHGDbov6wPtbUyzo7ib238t8uB3iOsJC2tviguvMgMlHgR3zV9AbVcJhRcEG MpEUIhbHJLXbIzrmM6WIvWPj6LiVQPiiLfUpW2v/Dt1Te8HANcRJD6aDL96DSpE= =3HPX -----END PGP SIGNATURE----- --cBSHaeLX28xRe7R6iDrwMr9x7n7hTOQIN--