From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39893) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wwfq6-0003Gw-G7 for qemu-devel@nongnu.org; Mon, 16 Jun 2014 18:57:27 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Wwfq1-0003Bl-Bt for qemu-devel@nongnu.org; Mon, 16 Jun 2014 18:57:22 -0400 Received: from mx1.redhat.com ([209.132.183.28]:51189) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wwfq1-0003Be-3a for qemu-devel@nongnu.org; Mon, 16 Jun 2014 18:57:17 -0400 Message-ID: <539F7649.10805@redhat.com> Date: Mon, 16 Jun 2014 16:57:13 -0600 From: Eric Blake MIME-Version: 1.0 References: <1401970944-18735-1-git-send-email-wenchaoqemu@gmail.com> <1401970944-18735-23-git-send-email-wenchaoqemu@gmail.com> In-Reply-To: <1401970944-18735-23-git-send-email-wenchaoqemu@gmail.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="qE6EkUE6KkBCEX0J7peUFRqi5c3e4Ntb9" Subject: Re: [Qemu-devel] [PATCH V6 22/29] qapi event: convert other BLOCK_JOB events List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Wenchao Xia , qemu-devel@nongnu.org Cc: mdroth@linux.vnet.ibm.com, armbru@redhat.com, lcapitulino@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --qE6EkUE6KkBCEX0J7peUFRqi5c3e4Ntb9 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 06/05/2014 06:22 AM, Wenchao Xia wrote: > Since BLOCK_JOB_COMPLETED, BLOCK_JOB_CANCELLED, BLOCK_JOB_READY are > related, converts them in one patch. The block_job_event_* functions s/converts/convert/ > are used to keep encapsulation of BlockJob structure. >=20 > Signed-off-by: Wenchao Xia > --- > block/mirror.c | 2 +- > blockdev.c | 12 +++---- > blockjob.c | 36 +++++++++++++---------- > docs/qmp/qmp-events.txt | 71 --------------------------------------= -------- > include/block/blockjob.h | 17 ++++++++-- > qapi-event.json | 71 ++++++++++++++++++++++++++++++++++++++= ++++++++ > 6 files changed, 110 insertions(+), 99 deletions(-) >=20 > -- "device": Device name (json-string) > -- "len": Maximum progress value (json-int) > -- "offset": Current progress value (json-int) > - On success this is equal to len. > - On failure this is less than len. > -- "speed": Rate limit, bytes per second (json-int) > -- "error": Error message (json-string, optional) > - Only present on failure. This field contains a human-re= adable > - error message. There are no semantics other than that s= treaming > - has failed and clients should not try to interpret the e= rror This sort of disclaimer is what I'm looking for in 21/29. > /** > - * qobject_from_block_job: > + * block_job_event_cancle: s/cancle/cancelled/ --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --qE6EkUE6KkBCEX0J7peUFRqi5c3e4Ntb9 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJTn3ZJAAoJEKeha0olJ0NqpTsH/3eWOfP/8QtzPZFXGzd9hgPV qpyLl7WgcgM56+LaykzI7HWprIdEqomCbpFD45h2wgCHAXlQN8Urp3RlJIwR2+Es Bs8sKCWXexfGVQvuMP0Pi3kjH8HzU+2yQdnTU+9ojyF9GI3HcHyv1I+N/RWM39uG iaH9nDqhX/j8xexWiVBlDAbeIOr6p2uEsCJHKsai0tBGHnUR0EiFQjBDIZcgdSu7 mYxXRoDb72qfBA1R8hqa4CMpHc5rJY++wI/l+W5wnve1BtA0AlIwQ+ClBd3V/k9g htqSuHbPvfzOg2rhYVEU+HGmkV9Le13p2a1CqUGRkL3oUthalblp0bQLSQqd6dQ= =/WoJ -----END PGP SIGNATURE----- --qE6EkUE6KkBCEX0J7peUFRqi5c3e4Ntb9--