From: Paolo Bonzini <pbonzini@redhat.com>
To: Fam Zheng <famz@redhat.com>, qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>, Stefan Hajnoczi <stefanha@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 5/6] virtio-blk: Unify {non-, }dataplane's request handlings
Date: Tue, 17 Jun 2014 06:27:55 +0200 [thread overview]
Message-ID: <539FC3CB.1010803@redhat.com> (raw)
In-Reply-To: <1402976701-10271-6-git-send-email-famz@redhat.com>
Il 17/06/2014 05:45, Fam Zheng ha scritto:
> @@ -275,6 +123,7 @@ void virtio_blk_data_plane_create(VirtIODevice *vdev, VirtIOBlkConf *blk,
> Error **errp)
> {
> VirtIOBlockDataPlane *s;
> + VirtIOBlock *vblk = VIRTIO_BLK(vdev);
> Error *local_err = NULL;
>
> *dataplane = NULL;
> @@ -317,6 +166,7 @@ void virtio_blk_data_plane_create(VirtIODevice *vdev, VirtIOBlkConf *blk,
> bdrv_op_block_all(blk->conf.bs, s->blocker);
>
> *dataplane = s;
> + vblk->complete_request = complete_request_early;
> }
This needs to be undone when dataplane is stopped.
Paolo
next prev parent reply other threads:[~2014-06-17 4:28 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-17 3:44 [Qemu-devel] [PATCH 0/6] virtio-blk: Unify request handling of dataplane Fam Zheng
2014-06-17 3:44 ` [Qemu-devel] [PATCH 1/6] block: make bdrv_query_stats() static Fam Zheng
2014-06-17 3:44 ` [Qemu-devel] [PATCH 2/6] block: acquire AioContext in qmp_query_blockstats() Fam Zheng
2014-06-17 3:44 ` [Qemu-devel] [PATCH 3/6] virtio-blk: Make request completion function virtual Fam Zheng
2014-06-17 3:44 ` [Qemu-devel] [PATCH 4/6] virtio-blk: Export request handling functions to dataplane Fam Zheng
2014-06-17 3:45 ` [Qemu-devel] [PATCH 5/6] virtio-blk: Unify {non-, }dataplane's request handlings Fam Zheng
2014-06-17 4:27 ` Paolo Bonzini [this message]
2014-06-17 3:45 ` [Qemu-devel] [PATCH 6/6] virtio-blk: Rename complete_request_early to complete_request_vring Fam Zheng
2014-06-17 4:29 ` [Qemu-devel] [PATCH 0/6] virtio-blk: Unify request handling of dataplane Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=539FC3CB.1010803@redhat.com \
--to=pbonzini@redhat.com \
--cc=famz@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).