From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:51511)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1Wwl0E-0000vy-4i
	for qemu-devel@nongnu.org; Tue, 17 Jun 2014 00:28:19 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1Wwl05-0004UX-3c
	for qemu-devel@nongnu.org; Tue, 17 Jun 2014 00:28:10 -0400
Received: from mail-wi0-x233.google.com ([2a00:1450:400c:c05::233]:63491)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1Wwl04-0004UR-SS
	for qemu-devel@nongnu.org; Tue, 17 Jun 2014 00:28:01 -0400
Received: by mail-wi0-f179.google.com with SMTP id cc10so5078893wib.0
	for <qemu-devel@nongnu.org>; Mon, 16 Jun 2014 21:27:59 -0700 (PDT)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <539FC3CB.1010803@redhat.com>
Date: Tue, 17 Jun 2014 06:27:55 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1402976701-10271-1-git-send-email-famz@redhat.com>
	<1402976701-10271-6-git-send-email-famz@redhat.com>
In-Reply-To: <1402976701-10271-6-git-send-email-famz@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 5/6] virtio-blk: Unify {non-,
	}dataplane's request handlings
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Fam Zheng <famz@redhat.com>, qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>, Stefan Hajnoczi <stefanha@redhat.com>

Il 17/06/2014 05:45, Fam Zheng ha scritto:
> @@ -275,6 +123,7 @@ void virtio_blk_data_plane_create(VirtIODevice *vdev, VirtIOBlkConf *blk,
>                                    Error **errp)
>  {
>      VirtIOBlockDataPlane *s;
> +    VirtIOBlock *vblk = VIRTIO_BLK(vdev);
>      Error *local_err = NULL;
>
>      *dataplane = NULL;
> @@ -317,6 +166,7 @@ void virtio_blk_data_plane_create(VirtIODevice *vdev, VirtIOBlkConf *blk,
>      bdrv_op_block_all(blk->conf.bs, s->blocker);
>
>      *dataplane = s;
> +    vblk->complete_request = complete_request_early;
>  }

This needs to be undone when dataplane is stopped.

Paolo