From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:52001)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1Wwl3C-0002tI-Er
	for qemu-devel@nongnu.org; Tue, 17 Jun 2014 00:31:20 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1Wwl36-0005OC-Pj
	for qemu-devel@nongnu.org; Tue, 17 Jun 2014 00:31:14 -0400
Received: from mail-we0-x236.google.com ([2a00:1450:400c:c03::236]:47501)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1Wwl36-0005O8-J6
	for qemu-devel@nongnu.org; Tue, 17 Jun 2014 00:31:08 -0400
Received: by mail-we0-f182.google.com with SMTP id q59so6653306wes.13
	for <qemu-devel@nongnu.org>; Mon, 16 Jun 2014 21:31:07 -0700 (PDT)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <539FC485.7070305@redhat.com>
Date: Tue, 17 Jun 2014 06:31:01 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1402939751-8371-1-git-send-email-somlo@cmu.edu>
	<539F7126.6070205@suse.de>
In-Reply-To: <539F7126.6070205@suse.de>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v1 0/3] e1000: link auto-negotiation fixes
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alexander Graf <agraf@suse.de>, "Gabriel L. Somlo" <gsomlo@gmail.com>, qemu-devel@nongnu.org
Cc: romain@dolbeau.org, afaerber@suse.de, stefanha@redhat.com, mst@redhat.com

Il 17/06/2014 00:35, Alexander Graf ha scritto:
>
> On 16.06.14 19:29, Gabriel L. Somlo wrote:
>> This series contains a few fixes and improvements in the emulation
>> of link auto-negotiation:
>>
>>    - use auto-negotiation when the link is bounced externally (e.g. via
>>      set_link <foo> down/up on the qemu monitor command line).
>>
>>    - allow mii_tool on linux access to all the phy registers and flags
>>      it requires in order to report a successfully auto-negotiated link.
>>
>>    - inject LSC interrupt upon successful link auto-negotiation (required
>>      by stock OS X e1000 driver).
>>
>> See additional prose following commit logs in 2/3 (making up excuses
>> for checkpatch error) and 3/3 (further thoughts on OS X vs. Linux/Windows
>> re. auto-negotiation and LSC injection).
>
> Looks very reasonable and straight forward to me.
>
> Reviewed-by: Alexander Graf <agraf@suse.de>

Would you pick it up and send a pull request for it?

Paolo