From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60563) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wwm4w-0004Ih-PK for qemu-devel@nongnu.org; Tue, 17 Jun 2014 01:37:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Wwm4q-00035S-Lm for qemu-devel@nongnu.org; Tue, 17 Jun 2014 01:37:06 -0400 Received: from mx1.redhat.com ([209.132.183.28]:1604) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wwm4q-00035G-Ec for qemu-devel@nongnu.org; Tue, 17 Jun 2014 01:37:00 -0400 Message-ID: <539FD3F1.2010304@redhat.com> Date: Tue, 17 Jun 2014 07:36:49 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1402974463.7661.102.camel@pasglop> <539FC6B9.6060003@redhat.com> <1402981184.7661.107.camel@pasglop> In-Reply-To: <1402981184.7661.107.camel@pasglop> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RFC] qemu VGA endian swap low level drawing changes List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Benjamin Herrenschmidt Cc: Alexey Kardashevskiy , Alexander Graf , "qemu-devel@nongnu.org" , Gerd Hoffmann Il 17/06/2014 06:59, Benjamin Herrenschmidt ha scritto: > Thanks. I've tried the other approach of adding new functions which > means no overhead (hopefully) for the non-swap case and less invasive > changes to vga_template.c. > > Patch below. What do you think ? This or the previous approach ? Then we > can discuss how we actually trigger the endian change and where we store > the state :-) This is definitely more readable. Anyway Gerd is the VGA guy. :) Paolo