From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36879) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wwp9N-00044X-CL for qemu-devel@nongnu.org; Tue, 17 Jun 2014 04:54:02 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Wwp9E-0005ox-AI for qemu-devel@nongnu.org; Tue, 17 Jun 2014 04:53:53 -0400 Received: from mail-we0-x235.google.com ([2a00:1450:400c:c03::235]:45073) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wwp9D-0005oi-R5 for qemu-devel@nongnu.org; Tue, 17 Jun 2014 04:53:44 -0400 Received: by mail-we0-f181.google.com with SMTP id q59so6911476wes.12 for ; Tue, 17 Jun 2014 01:53:42 -0700 (PDT) Sender: Paolo Bonzini Message-ID: <53A00213.1030708@redhat.com> Date: Tue, 17 Jun 2014 10:53:39 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1402986730-25642-1-git-send-email-famz@redhat.com> In-Reply-To: <1402986730-25642-1-git-send-email-famz@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 0/7] virtio-blk: Unify request handling of dataplane List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Fam Zheng , qemu-devel@nongnu.org Cc: Kevin Wolf , Stefan Hajnoczi Il 17/06/2014 08:32, Fam Zheng ha scritto: > v2: Address Paolo's comments: > > * Schedule restart BH in the right AioContext. > * Restore ->complete_request when stopping dataplane. > > This is based on top of my request converging series: > > [PATCH v4 0/9] virtio-blk: Converge VirtIOBlockRequest into VirtIOBlockReq > > Most of the request handlings are already the same now between dataplane and > non-dataplane, except the missing IO accounting, error reporting and > multiwrite. With this series, dataplane pulls in all of them by reusing > non-dataplane handling code. > > Thread safety of error reporting relies on Paolo's series: > > [PATCH 0/5] qemu-char/monitor: make monitor_puts thread safe > > [PATCH v2 0/2] block: thread-safety patches for virtio-blk dataplane > rerror/werror > > Fam Zheng (5): > virtio-blk: Make request completion function virtual > virtio-blk: Export request handling functions to dataplane > virtio-blk: Schedule BH in the right context > virtio-blk: Unify {non-,}dataplane's request handlings > virtio-blk: Rename complete_request_early to complete_request_vring > > Stefan Hajnoczi (2): > block: make bdrv_query_stats() static > block: acquire AioContext in qmp_query_blockstats() > > block/qapi.c | 6 +- > hw/block/dataplane/virtio-blk.c | 185 +++++----------------------------------- > hw/block/virtio-blk.c | 22 ++--- > include/block/qapi.h | 1 - > include/hw/virtio/virtio-blk.h | 12 +++ > 5 files changed, 49 insertions(+), 177 deletions(-) > Tested-by: Paolo Bonzini Paolo