From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42676) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WwpcE-0006Cr-Pv for qemu-devel@nongnu.org; Tue, 17 Jun 2014 05:23:51 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Wwpc5-0007AI-PY for qemu-devel@nongnu.org; Tue, 17 Jun 2014 05:23:42 -0400 Received: from mail-qc0-x236.google.com ([2607:f8b0:400d:c01::236]:60484) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wwpc5-00079Q-Fa for qemu-devel@nongnu.org; Tue, 17 Jun 2014 05:23:33 -0400 Received: by mail-qc0-f182.google.com with SMTP id m20so9697790qcx.13 for ; Tue, 17 Jun 2014 02:23:33 -0700 (PDT) Sender: Paolo Bonzini Message-ID: <53A00911.2090907@redhat.com> Date: Tue, 17 Jun 2014 11:23:29 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1401970944-18735-1-git-send-email-wenchaoqemu@gmail.com> <1401970944-18735-18-git-send-email-wenchaoqemu@gmail.com> <539B7164.1030407@redhat.com> In-Reply-To: <539B7164.1030407@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH V6 17/29] qapi event: convert WATCHDOG List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake , Wenchao Xia , qemu-devel@nongnu.org Cc: lcapitulino@redhat.com, mdroth@linux.vnet.ibm.com, armbru@redhat.com Il 13/06/2014 23:47, Eric Blake ha scritto: >> +## >> > +# @WatchdogExpirationAction > I think you will be better off to ensure that error.json is > self-sufficient, perhaps by sticking any data type it references > directly into common.json rather than qapi-schema.json, and having > error.json include common.json. (This is the first instance of > referencing an external type, but other events later in the series have > the same issue). > Can be done later though, I think? Paolo