From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51976) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WwqIW-00071P-Ll for qemu-devel@nongnu.org; Tue, 17 Jun 2014 06:07:33 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WwqIN-0005en-LZ for qemu-devel@nongnu.org; Tue, 17 Jun 2014 06:07:24 -0400 Received: from mail-la0-x22a.google.com ([2a00:1450:4010:c03::22a]:43391) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WwqIN-0005ea-Ct for qemu-devel@nongnu.org; Tue, 17 Jun 2014 06:07:15 -0400 Received: by mail-la0-f42.google.com with SMTP id el20so3806221lab.1 for ; Tue, 17 Jun 2014 03:07:13 -0700 (PDT) Message-ID: <53A0134F.6040402@gmail.com> Date: Tue, 17 Jun 2014 14:07:11 +0400 From: Sergey Fedorov MIME-Version: 1.0 References: <1402444514-19658-1-git-send-email-aggelerf@ethz.ch> <1402444514-19658-8-git-send-email-aggelerf@ethz.ch> <20140617091506.GH10398@toto> In-Reply-To: <20140617091506.GH10398@toto> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v3 07/32] target-arm: add non-secure Translation Block flag List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Edgar E. Iglesias" , Fabian Aggeler Cc: peter.maydell@linaro.org, peter.crosthwaite@xilinx.com, qemu-devel@nongnu.org, christoffer.dall@linaro.org, greg.bellows@linaro.org On 17.06.2014 13:15, Edgar E. Iglesias wrote: > Hi, I think the patch looks OK but I'm unsure if it brings any benefits > unless we add separate TLBs for S and NS. > > I noticed that TTBR0 gets banked in the series, but are changes to > SCR.NS flushing the TLBs? I might have missed that from the patches. > You'll need it unless we add separate S/NS TLBs. > > Considering that changes to SCR.NS will flush the TLBs, the > use of a per TB ns flag is limited, unless I am missing something... Hi Edgar, This seems to be used in patch 19/32. // Sergey > > Cheers, > Edgar