From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:48103)
	by lists.gnu.org with esmtp (Exim 4.71) (envelope-from <pl@kamp.de>)
	id 1WwruW-0001SH-81
	for qemu-devel@nongnu.org; Tue, 17 Jun 2014 07:50:51 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pl@kamp.de>) id 1WwruP-0000Ai-Ch
	for qemu-devel@nongnu.org; Tue, 17 Jun 2014 07:50:44 -0400
Received: from mx-v6.kamp.de ([2a02:248:0:51::16]:54566 helo=mx01.kamp.de)
	by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <pl@kamp.de>)
	id 1WwruO-0000AS-QV
	for qemu-devel@nongnu.org; Tue, 17 Jun 2014 07:50:37 -0400
Message-ID: <53A02B7D.50909@kamp.de>
Date: Tue, 17 Jun 2014 13:50:21 +0200
From: Peter Lieven <pl@kamp.de>
MIME-Version: 1.0
References: <1401889659-24035-1-git-send-email-pl@kamp.de>
	<CAN05THTaDzwHf-A0SmAGgmODhoqsGoyyn7apiBmnwYeFBQc63Q@mail.gmail.com>
	<53903469.8070902@msgid.tls.msk.ru> <539FDCAD.5060006@kamp.de>
	<53A02351.8060900@redhat.com> <53A02867.7090400@kamp.de>
	<53A02AA6.2060006@redhat.com>
In-Reply-To: <53A02AA6.2060006@redhat.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Subject: Re: [Qemu-devel] [PATCH] block/iscsi: use 16 byte CDBs only when
 necessary
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>, Michael Tokarev <mjt@tls.msk.ru>, ronnie sahlberg <ronniesahlberg@gmail.com>
Cc: Kevin Wolf <kwolf@redhat.com>, qemu-devel <qemu-devel@nongnu.org>, Stefan Hajnoczi <stefanha@redhat.com>

On 17.06.2014 13:46, Paolo Bonzini wrote:
> Il 17/06/2014 13:37, Peter Lieven ha scritto:
>> On 17.06.2014 13:15, Paolo Bonzini wrote:
>>> Il 17/06/2014 08:14, Peter Lieven ha scritto:
>>>>>
>>>>
>>>> BTW, while debugging a case with a bigger storage supplier I found
>>>> that open-iscsi seems to do exactly this undeterministic behaviour.
>>>> I have a 3TB LUN. If I access < 2TB sectors it uses READ10/WRITE10 and
>>>> if I go beyond 2TB it changes to READ16/WRITE16.
>>>
>>> Isn't that exactly what your latest patch does for >64K sector writes? :)
>>
>> Not exactly, we choose the default by checking the LUN size. 10 Byte for
>> < 2TB and 16 Byte otherwise.
>
> Yeah, I meant introducing the non-determinism.

Ah okay :-)

>
>> My latest patch makes an exception if a request is bigger than 64K
>> sectors and
>> switches to 16 Byte requests. These would otherwise end in an I/O error.
>
> It could also be split at the block layer, like we do for unmap. I think there's also a maximum transfer size somewhere in the VPD, we could to READ16/WRITE16 if it is >64K sectors.

That would be an idea. I will have a look.

Peter

>
> Paolo


-- 

Mit freundlichen Grüßen

Peter Lieven

...........................................................

   KAMP Netzwerkdienste GmbH
   Vestische Str. 89-91 | 46117 Oberhausen
   Tel: +49 (0) 208.89 402-50 | Fax: +49 (0) 208.89 402-40
   pl@kamp.de | http://www.kamp.de

   Geschäftsführer: Heiner Lante | Michael Lante
   Amtsgericht Duisburg | HRB Nr. 12154
   USt-Id-Nr.: DE 120607556

...........................................................