From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48863) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WwryR-0003dZ-Cv for qemu-devel@nongnu.org; Tue, 17 Jun 2014 07:54:54 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WwryK-0001QV-59 for qemu-devel@nongnu.org; Tue, 17 Jun 2014 07:54:47 -0400 Received: from mx1.redhat.com ([209.132.183.28]:14410) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WwryJ-0001QI-TB for qemu-devel@nongnu.org; Tue, 17 Jun 2014 07:54:40 -0400 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s5HBsaG4023181 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Tue, 17 Jun 2014 07:54:38 -0400 Message-ID: <53A02C7B.2010901@redhat.com> Date: Tue, 17 Jun 2014 05:54:35 -0600 From: Eric Blake MIME-Version: 1.0 References: <20140616231509.GA24935@amt.cnet> <1402995735.1614.8.camel@nilsson.home.kraxel.org> In-Reply-To: <1402995735.1614.8.camel@nilsson.home.kraxel.org> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="me7W5RxohTdFMwu8peFgq0qrdXkqLuMLC" Subject: Re: [Qemu-devel] [PATCH] add input-send-event command List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerd Hoffmann , Marcelo Tosatti Cc: qemu-devel , Luiz Capitulino This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --me7W5RxohTdFMwu8peFgq0qrdXkqLuMLC Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 06/17/2014 03:02 AM, Gerd Hoffmann wrote: > On Mo, 2014-06-16 at 20:15 -0300, Marcelo Tosatti wrote: >> Which allows specification of absolute/relative,=20 >> up/down and console parameters. >=20 > Looks good overall, only minor nits. Will wait for acks from qmp guys > before picking into input branch. >=20 >> Suggested by Gerd Hoffman. >=20 > Huh? Signed-off missing ... >=20 >> +Press left mouse button. >> + >> +-> { "execute": "input-send-event", >> + "arguments": { "console": 0, >> + "events": [ { "type": "btn", >> + "data" : { "down": true, "button": "Left" } }, >> + { "type": "btn", >> + "data" : { "down": false, "button": "Left" } } = ] } } >> +<- { "return": {} } >=20 > Bad example. Down + up should go as separate commands (so you have a > sync inbetween), otherwise it might happen that the guest doesn't see > the button event at all. Would it be worth adding a command to the union of possible events that adds a pause? As in: -> { "execute": "input-send-event", "arguments": { "console": 0, "events": [ { "type": "btn", "data" : { "down": true, "button": "Left" } }, { "type": "pause", "data": { "duration": 10 } }, { "type": "btn", "data" : { "down": false, "button": "Left" } } ] } = } that sticks a 10 ms delay between the other two events? --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --me7W5RxohTdFMwu8peFgq0qrdXkqLuMLC Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJToCx7AAoJEKeha0olJ0Nq5IUH/00TCtwKgv02mCvK8J7FbDC0 rocLE8ZZc3r6VJjSTxGxxAmJbdIngRa8dvhWq7VmYfLEMG0t9jxTyTNeRnA+YKYY vLi6vxp0OlI+qpHraXlbJxHnwCy6QvmGEoLyqhSgaQbBeGukIRXUVlk/nfpCKyj9 q56I+3MiYcxPpr5WkwTo9RNG+r4UT7DNFKLD4lojTE4tBQDmwdEyGIhdae6qbk8p OjhMZmLnjHX/8dI0kY/GaxO3Thyhq4Ug74n6NFAFqS0OvjPeok808dc0JSBYdfVb vtvHd8J+xntNNflEAwU84CDCjuo7o/jCqXlCHmaCPnb1zboSGxbgjSp/ZDUeRDA= =Ob9h -----END PGP SIGNATURE----- --me7W5RxohTdFMwu8peFgq0qrdXkqLuMLC--